Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Windows-only tests only on Windows #105003

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Run Windows-only tests only on Windows #105003

merged 2 commits into from
Dec 1, 2022

Conversation

flba-eb
Copy link
Contributor

@flba-eb flba-eb commented Nov 28, 2022

This removes the need to maintain an ignore-list of all other OSs.

See #102305 for a similar change.

@flba-eb
Run Windows-only tests only on Windows
3e72a01 
This removes the need to maintain a list of all other
OSs which ignore the tests.
@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2022
@flba-eb flba-eb marked this pull request as ready for review November 28, 2022 07:50
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 30, 2022

📌 Commit 3e72a01 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#105003 - flba-eb:only_windows, r=Mark-Simul…
5ffc473 
…acrum

Run Windows-only tests only on Windows

This removes the need to maintain an ignore-list of all other OSs.

See rust-lang#102305 for a similar change.
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Dec 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#105003 - flba-eb:only_windows, r=Mark-Simul…
2377177 
…acrum

Run Windows-only tests only on Windows

This removes the need to maintain an ignore-list of all other OSs.

See rust-lang#102305 for a similar change.
@Dylan-DPC Dylan-DPC mentioned this pull request Dec 1, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r- failed in a rollup
https://github.com/rust-lang-ci/rust/actions/runs/3591507532/jobs/6046125756#step:26:8103
#105118

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 1, 2022
@ChrisDenton
Copy link
Member

These tests are windows-msvc only, so windows-gnu will not work.

@flba-eb
Copy link
Contributor Author

flba-eb commented Dec 1, 2022

@ChrisDenton : Thanks for taking a look at it! gnu is now ignored. I tested the combination of only and ignore with only-unix, it works as expected. Wasn't able to test with windows though.

Issue should be resolved now.

@flba-eb
Copy link
Contributor Author

flba-eb commented Dec 1, 2022 •
edited
Loading

@ChrisDenton , hmm, are we sure that the second test src/test/codegen/panic-abort-windows.rs really only works in msvc (as the comment suggests)? I'm asking because:

  • gnu was not ignored before
  • I think this test did not fail

If you agree I would remove the ignore-gnu line in the test and update the comment.

@ChrisDenton
Copy link
Member

Oh hm you're right. Yeah the comment should definitely be updated as well.

@flba-eb
Copy link
Contributor Author

flba-eb commented Dec 1, 2022

@ChrisDenton done. Please review 😄

ChrisDenton
ChrisDenton approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Dec 1, 2022

📌 Commit c04d674 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 1, 2022
@bors
Copy link
Contributor

bors commented Dec 1, 2022

⌛ Testing commit c04d674 with merge 367ecff...

@bors
Copy link
Contributor

bors commented Dec 1, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 367ecff to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 1, 2022
@bors bors merged commit 367ecff into rust-lang:master Dec 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 1, 2022
@flba-eb flba-eb deleted the only_windows branch December 1, 2022 18:50
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (367ecff): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.6% [4.6%, 4.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.3% [-5.3%, -5.3%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)		 -2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#105003 - flba-eb:only_windows, r=Mark-Simulacrum
bc2454d 
Run Windows-only tests only on Windows

This removes the need to maintain an ignore-list of all other OSs.

See rust-lang#102305 for a similar change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
7 participants
@flba-eb @rustbot @Mark-Simulacrum @bors @matthiaskrgr @ChrisDenton @rust-timer