-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test/ui/issues/issue-30490.rs #104419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the empty main is used for `not(unix)`, all the targets that will use this empty main will also need `allow(unused_imports)`. Originally part of rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 14, 2022
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 15, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 16, 2022
Fix test/ui/issues/issue-30490.rs Since the empty main is used for `not(unix)`, all the targets that will use this empty main will also need `allow(unused_imports)`. Originally part of rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Nov 16, 2022
Fix test/ui/issues/issue-30490.rs Since the empty main is used for `not(unix)`, all the targets that will use this empty main will also need `allow(unused_imports)`. Originally part of rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 16, 2022
Fix test/ui/issues/issue-30490.rs Since the empty main is used for `not(unix)`, all the targets that will use this empty main will also need `allow(unused_imports)`. Originally part of rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2022
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#103484 (Add `rust` to `let_underscore_lock` example) - rust-lang#103489 (Make `pointer::byte_offset_from` more generic) - rust-lang#104193 (Shift no characters when using raw string literals) - rust-lang#104348 (Respect visibility & stability of inherent associated types) - rust-lang#104401 (avoid memory leak in mpsc test) - rust-lang#104419 (Fix test/ui/issues/issue-30490.rs) - rust-lang#104424 (rustdoc: remove no-op CSS `.popover { font-size: 1rem }`) - rust-lang#104425 (rustdoc: remove no-op CSS `.main-header { justify-content }`) - rust-lang#104450 (Fuchsia test suite script fix) - rust-lang#104471 (Update PROBLEMATIC_CONSTS in style.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the empty main is used for
not(unix)
, all the targets that will use this empty main will also needallow(unused_imports)
.Originally part of #100316
Signed-off-by: Ayush Singh ayushsingh1325@gmail.com