Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: a few fixes #10421

Merged
merged 4 commits into from
Nov 13, 2013
Merged

doc: a few fixes #10421

merged 4 commits into from
Nov 13, 2013

Conversation

adrientetar
Copy link
Contributor

@adrientetar
Copy link
Contributor Author

@alexcrichton How does it looks?
I used http://stackoverflow.com/a/649462.

@alexcrichton
Copy link
Member

It's not really necessary to use DEFINE, you can just use a normal variable like PANDOC_OPTS := -flag a -flag b etc.

Also, it still seems like there's quite a few flags shared among all the rules:

--to
--section-divs
--standalone
--toc
--number-sections
--from
--css

etc.

@adrientetar
Copy link
Contributor Author

@alexcrichton Long lines but oh well. So I made flags for each filetype.

@alexcrichton
Copy link
Member

You can interpolate makefile variables into others, so you can have a scheme like:

BASE_PANDOC_OPTS := -a -b -c
TEX_OPTS = $(BASE_PANDOC_OPTS) -d -e -f
HTML_OPTS = $(BASE_PANDOC_OPTS) -h -i -j

@adrientetar
Copy link
Contributor Author

@alexcrichton Done.

What's the difference between := and =?
EDIT: http://www.gnu.org/software/make/manual/html_node/Overriding.html#Overriding

@alexcrichton
Copy link
Member

There is a difference in makefile land, but to me it's just magical. I normally just pick the one that works and/or doesn't spit out errors.

That being said, the actual difference is that := is expanded when it's defined, but = is expanded when it's used. http://www.gnu.org/software/make/manual/make.html#Flavors probably has more information than I could give anyway :)

@adrientetar
Copy link
Contributor Author

@alexcrichton Can you r+ again? I just updated a reference for #10423. ty!

@adrientetar
Copy link
Contributor Author

@alexcrichton Nasty bitrot.

Since tutorial/manual files are stored on static.rust-lang.org, browsers
try to fetch the favicon from there while it should be retrieved from the
main domain.
@adrientetar
Copy link
Contributor Author

@alexcrichton Fixed.

bors added a commit that referenced this pull request Nov 13, 2013
* Closes #10330
* Improves on #9873
* Adds favicon for tutorial files
@bors bors closed this Nov 13, 2013
@bors bors merged commit 3d57b24 into rust-lang:master Nov 13, 2013
@adrientetar adrientetar deleted the patch-www branch December 15, 2013 11:49
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 24, 2023
Fix `almost_swapped` false positive (`let mut a = b; a = a`)

Fixes `2` in rust-lang#10421
changelog: [`almost_swapped`]: Fix false positive when a variable is changed to itself. (`a = a`)
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 24, 2023
fix `almost_swapped`: Ignore external macros

Fixes rust-lang#10421 ; Related to rust-lang#10499 (Fixing points *1* and *3* from rust-lang#10421)
changelog: [`almost_swapped`]: Add a check to ignore external macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc: monospaced font appears too large on a Retina display
3 participants