LLVM 16: Switch to using MemoryEffects #103977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
nikic
added
the
llvm-main
durin42
reviewed
Nov 4, 2022
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103868 (Use `TraitEngine` (by itself) less) - rust-lang#103878 (Fix artifact version/channel detection for stable) - rust-lang#103946 (Cleanup bind_pattern args) - rust-lang#103956 (Make mir opt unused file check blessable) - rust-lang#103977 (LLVM 16: Switch to using MemoryEffects) - rust-lang#103980 (rustdoc: simplify search results CSS and DOM) - rust-lang#103984 (Refactor tcx mk_const parameters.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 22, 2022
Update nightly release from 2022-11-01 to 2022-11-18 Rolls in: * rust-lang/rust#103367 * rust-lang/rust#103977 Fixed: 1383950 Change-Id: I60ad4a8209eafac4d944a9f6ef873359062dd1ba No-Try: true Change-Id: I60ad4a8209eafac4d944a9f6ef873359062dd1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4013723 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/main@{#1074798}
oneseer
pushed a commit
to oneseer/rust
that referenced
this pull request
May 24, 2025
Update nightly release from 2022-11-01 to 2022-11-18 Rolls in: * rust-lang/rust#103367 * rust-lang/rust#103977 Fixed: 1383950 Change-Id: I60ad4a8209eafac4d944a9f6ef873359062dd1ba No-Try: true Change-Id: I60ad4a8209eafac4d944a9f6ef873359062dd1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4013723 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/main@{#1074798} NOKEYCHECK=True GitOrigin-RevId: bdf18dd2cdd6d27b6fb5705ca665ca08379175ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the compiler to the changes required by llvm/llvm-project@304f1d5.
AFAICT,
WriteOnlyisn't used by the compiler, allReadNoneuses were migrated and the remaining use ofReadOnlyis only for function parameters.To simplify the FFI, this PR uses an enum to represent
MemoryEffectsacross the FFI boundary, which then gets mapped to the matching static factory method when constructing the attribute.Fixes #103961.
@rustbot label +llvm-main
r? @nikic