Skip to content

Remove an option and choose a behaviour-preserving default instead. #103972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2022
Merged

Remove an option and choose a behaviour-preserving default instead. #103972

merged 1 commit into from
Nov 5, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 4, 2022

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @fee1-dead (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2022
@fee1-dead
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 5, 2022

📌 Commit a2325fe has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 5, 2022
@matthiaskrgr
Rollup merge of rust-lang#103972 - oli-obk:unoptional, r=fee1-dead
ceb24da 
Remove an option and choose a behaviour-preserving default instead.

r? `@fee1-dead`
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 5, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 5, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2022
@bors
Auto merge of rust-lang#104017 - matthiaskrgr:rollup-k8i0j9m, r=matth…
371100b 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#101702 (rustdoc: add hash to filename of toolchain files)
 - rust-lang#103920 (Move browser opening logic in `Builder`)
 - rust-lang#103927 (Do not make typo suggestions when suggesting pattern matching)
 - rust-lang#103972 (Remove an option and choose a behaviour-preserving default instead.)
 - rust-lang#103988 (Fix search result bottom border color)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cf2d88d into rust-lang:master Nov 5, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oli-obk @rustbot @fee1-dead @bors