Stabilize `::{core,std}::pin::pin!` #103800

danielhenrymantilla · 2022-10-31T12:21:20Z

As discussed over here, it looks like a decent time to stabilize the pin! macro.

Public API

// in module `core::pin`

/// API: `fn pin<T>($value: T) -> Pin<&'local mut T>`
pub macro pin($value:expr $(,)?) {
    …
}

Tracking issue: Tracking Issue for core::pin::pin! #93178

(now all this needs is an FCP by the proper team?)

rustbot · 2022-10-31T12:21:26Z

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2022-10-31T12:21:29Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

The Miri subtree was changed

cc @rust-lang/miri

src/tools/miri/tests/pass/issues/issue-miri-2068.rs

scottmcm · 2022-11-09T05:10:06Z

Since this needs an FCP, which I can't do,
r? rust-lang/libs-api

yoshuawuyts · 2022-11-10T17:05:54Z

cc/ @rust-lang/libs-api, @rust-lang/wg-async

danielhenrymantilla · 2022-12-13T11:33:20Z

@rustbot modify labels: -S-waiting-on-review +S-waiting-on-team

m-ou-se · 2022-12-13T16:42:45Z

@rfcbot merge

rfcbot · 2022-12-13T16:42:47Z

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

dtolnay · 2022-12-20T20:37:51Z

I'm marking @yaahc's box because she has stepped down from T-libs-api after the point that this feature got proposed for FCP.

…macro, r=dtolnay Stabilize `::{core,std}::pin::pin!` As discussed [over here](rust-lang#93178 (comment)), it looks like a decent time to stabilize the `pin!` macro. ### Public API ```rust // in module `core::pin` /// API: `fn pin<T>($value: T) -> Pin<&'local mut T>` pub macro pin($value:expr $(,)?) { … } ``` - Tracking issue: rust-lang#93178 (now all this needs is an FCP by the proper team?)

JohnTitor · 2023-01-08T08:04:42Z

@bors r-
This needs a rebase to remove more feature gates.

dtolnay · 2023-01-10T15:27:39Z

@bors r+

bors · 2023-01-10T15:27:41Z

📌 Commit 980d09b7350efc7e56e22ad6a05f2af6c68a93be has been approved by dtolnay

It is now in the queue for this repository.

bors · 2023-01-10T15:27:42Z

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

dtolnay · 2023-01-11T22:11:00Z

Rebased to resolve conflict with #106458.
@bors r+

bors · 2023-01-11T22:11:31Z

📌 Commit 48b7e2a has been approved by dtolnay

It is now in the queue for this repository.

…macro, r=dtolnay Stabilize `::{core,std}::pin::pin!` As discussed [over here](rust-lang#93178 (comment)), it looks like a decent time to stabilize the `pin!` macro. ### Public API ```rust // in module `core::pin` /// API: `fn pin<T>($value: T) -> Pin<&'local mut T>` pub macro pin($value:expr $(,)?) { … } ``` - Tracking issue: rust-lang#93178 (now all this needs is an FCP by the proper team?)

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#103236 (doc: rewrite doc for signed int::{carrying_add,borrowing_sub}) - rust-lang#103800 (Stabilize `::{core,std}::pin::pin!`) - rust-lang#106097 (Migrate mir_build diagnostics 2 of 3) - rust-lang#106170 (Move autoderef to `rustc_hir_analysis`) - rust-lang#106323 (Stabilize f16c_target_feature) - rust-lang#106360 (Tweak E0277 `&`-removal suggestions) - rust-lang#106524 (Label `struct/enum constructor` instead of `fn item`, mention that it should be called on type mismatch) - rust-lang#106739 (Remove `<dyn AstConv<'tcx>>::fun(c, ...)` calls in favour of `c.astconv().fun(...)`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned scottmcm Oct 31, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 31, 2022

danielhenrymantilla mentioned this pull request Oct 31, 2022

Tracking Issue for core::pin::pin! #93178

Closed

4 tasks

danielhenrymantilla commented Oct 31, 2022

View reviewed changes

src/tools/miri/tests/pass/issues/issue-miri-2068.rs Outdated Show resolved Hide resolved

danielhenrymantilla force-pushed the stabilize-pin-macro branch from 8a88a62 to 0b3061a Compare October 31, 2022 12:57

rustbot assigned BurntSushi and unassigned scottmcm Nov 9, 2022

scottmcm added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Nov 9, 2022

Mark-Simulacrum assigned joshtriplett and unassigned BurntSushi Nov 13, 2022

rustbot added S-waiting-on-team DEPRECATED: Use the team-based variants `S-waiting-on-t-lang`, `S-waiting-on-t-compiler`, ... and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 13, 2022

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 28, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team DEPRECATED: Use the team-based variants `S-waiting-on-t-lang`, `S-waiting-on-t-compiler`, ... labels Jan 7, 2023

JohnTitor mentioned this pull request Jan 8, 2023

Rollup of 9 pull requests #106587

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2023

danielhenrymantilla force-pushed the stabilize-pin-macro branch 3 times, most recently from 281855b to 980d09b Compare January 10, 2023 14:03

dtolnay approved these changes Jan 10, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 10, 2023

Stabilize ::{core,std}::pin::pin!

48b7e2a

dtolnay force-pushed the stabilize-pin-macro branch from 980d09b to 48b7e2a Compare January 11, 2023 22:10

Dylan-DPC mentioned this pull request Jan 12, 2023

Rollup of 7 pull requests #106758

Closed

compiler-errors mentioned this pull request Jan 12, 2023

Rollup of 8 pull requests #106760

Merged

bors merged commit 2e17a5d into rust-lang:master Jan 12, 2023

rustbot added this to the 1.68.0 milestone Jan 12, 2023

apiraino removed the to-announce Announce this issue on triage meeting label Jan 12, 2023

ojeda mentioned this pull request Apr 1, 2023

Rust unstable features needed for the kernel Rust-for-Linux/linux#2

Open

jubrad mentioned this pull request Jun 27, 2023

use reqwest_retry to automatically retry failed requests MaterializeInc/rust-frontegg#13

Merged

Stabilize ::{core,std}::pin::pin! #103800

Stabilize ::{core,std}::pin::pin! #103800

Uh oh!

Conversation

danielhenrymantilla commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Public API

Uh oh!

rustbot commented Oct 31, 2022

Uh oh!

rustbot commented Oct 31, 2022

Uh oh!

Uh oh!

scottmcm commented Nov 9, 2022

Uh oh!

yoshuawuyts commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielhenrymantilla commented Dec 13, 2022

Uh oh!

m-ou-se commented Dec 13, 2022

Uh oh!

rfcbot commented Dec 13, 2022 • edited by BurntSushi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtolnay commented Dec 20, 2022

Uh oh!

JohnTitor commented Jan 8, 2023

Uh oh!

dtolnay commented Jan 10, 2023

Uh oh!

bors commented Jan 10, 2023

Uh oh!

bors commented Jan 10, 2023

Uh oh!

dtolnay commented Jan 11, 2023

Uh oh!

bors commented Jan 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Stabilize `::{core,std}::pin::pin!` #103800

Stabilize `::{core,std}::pin::pin!` #103800

danielhenrymantilla commented Oct 31, 2022 •

edited

Loading

yoshuawuyts commented Nov 10, 2022 •

edited

Loading

rfcbot commented Dec 13, 2022 •

edited by BurntSushi

Loading