Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #103797

Merged
merged 18 commits into from
Oct 31, 2022
Merged

Rollup of 5 pull requests #103797

merged 18 commits into from
Oct 31, 2022

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

l4l and others added 18 commits October 21, 2022 12:56
…f inferred"

This reverts commit 3acb505
(PR rust-lang#101833).

The changes in this commit caused several bugs or at least
incompatibilies. For now we're reverting this commit and will re-land it
alongside fixes for those bugs.
Fix unreachable_pub suggestion for enum with fields

Resolves rust-lang#103317
Lang item cleanups

Various cleanups related to lang items.
…iltins, r=jyn514

Revert "Make the `c` feature for `compiler-builtins` opt-in instead of inferred"

This reverts commit 3acb505 (PR rust-lang#101833).

The changes in this commit caused several bugs/incompatibilities (rust-lang#101833 (comment), rust-lang#102560). For now we're reverting this commit and will re-land it alongside fixes for those bugs.

Re-opens rust-lang#101172
cc rust-lang#102560
cc rust-lang#102579
Add tracking issue to `error_in_core`

This was merged in rust-lang#99917 without a tracking issue, so I'm creating one now: rust-lang#103765
Update E0382.md

Remove extra period after sentence.
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 31, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 31, 2022

📌 Commit 4a254d5 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2022
@Dylan-DPC
Copy link
Member Author

@bors rollup=never

@Dylan-DPC
Copy link
Member Author

@bors p=5

@bors
Copy link
Contributor

bors commented Oct 31, 2022

⌛ Testing commit 4a254d5 with merge 2afca78...

@bors
Copy link
Contributor

bors commented Oct 31, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 2afca78 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 31, 2022
@bors bors merged commit 2afca78 into rust-lang:master Oct 31, 2022
@rustbot rustbot added this to the 1.67.0 milestone Oct 31, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#103789 e83679f195c739b631eda23a1be5033836da08d7
#103766 aa487e3c430a96722f75da1faa114be61555cb70
#103732 6c6372b2e0adcd79e8939389b0ab3bc5815cc3f2
#103603 73947711cd2610d6c437790f4592cb0364765e22
#103338 50dcae454f40d85b19fbbf2145a9f6848db27d01

previous master: 4596f4f8b5

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2afca78): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants