Skip to content

Retain ParamEnv constness when running deferred cast checks #103683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2022
Merged

Retain ParamEnv constness when running deferred cast checks #103683

merged 1 commit into from
Oct 28, 2022

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Oct 28, 2022

Fixes #103677.

@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2022

r? @estebank

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fee1-dead fee1-dead force-pushed the fix-deferred-cast-checks-constness branch from 3a0b9b0 to 6000491 Compare October 28, 2022 11:54
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fee1-dead fee1-dead force-pushed the fix-deferred-cast-checks-constness branch from 6000491 to a990b4c Compare October 28, 2022 12:03
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@fee1-dead
Copy link
Member Author

fee1-dead commented Oct 28, 2022

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned estebank Oct 28, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Oct 28, 2022

@bors r+ p=1 (prioritizing, as it could make the beta cut and avoid a beta backport)

@bors
Copy link
Collaborator

bors commented Oct 28, 2022

📌 Commit a990b4c has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2022
@Dylan-DPC
Copy link
Member

Dylan-DPC commented Oct 28, 2022

@bors p=10

@bors
Copy link
Collaborator

bors commented Oct 28, 2022

⌛ Testing commit a990b4c with merge 9565dfe...

@bors
Copy link
Collaborator

bors commented Oct 28, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 9565dfe to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2022
@bors bors merged commit 9565dfe into rust-lang:master Oct 28, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 28, 2022
@rust-timer
Copy link
Collaborator

rust-timer commented Oct 29, 2022

Finished benchmarking commit (9565dfe): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@fee1-dead fee1-dead deleted the fix-deferred-cast-checks-constness branch November 3, 2022 15:13
@oli-obk oli-obk mentioned this pull request Oct 30, 2025
Merged
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 31, 2025
@Zalathar
Rollup merge of rust-lang#148287 - oli-obk:push-osluqnunqkyl, r=fee1-…
43cb58d 
…dead

Fix deferred cast checks using the wrong body for determining constness

re-introduces rust-lang#103683

it was lost in rust-lang@4fec845

deferred checks possibly have more such issues, needs investigation.

r? `@fee1-dead`
rust-timer added a commit that referenced this pull request Oct 31, 2025
@rust-timer
Unrolled build for #148287
5214f01 
Rollup merge of #148287 - oli-obk:push-osluqnunqkyl, r=fee1-dead

Fix deferred cast checks using the wrong body for determining constness

re-introduces #103683

it was lost in 4fec845

deferred checks possibly have more such issues, needs investigation.

r? `@fee1-dead`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

Compilation error with nightly: the trait ~const Deref is not implemented for String

8 participants

@fee1-dead @rustbot @rust-log-analyzer @oli-obk @bors @Dylan-DPC @rust-timer @estebank