Make std tests pass on newer Android #102757

pcc · 2022-10-06T22:01:32Z

Newer versions of Android forbid the creation of hardlinks as well as Unix domain sockets in the /data filesystem via SELinux rules, which causes several tests depending on this behavior to fail. So let's skip these tests on Android if we see an EACCES from one of these syscalls. To achieve this, introduce a macro with the horrible name of or_panic_or_skip_on_android_eacces (better suggestions welcome) which skips (returns from) the test if an EACCES return value is seen on Android.

rust-highfive · 2022-10-06T22:01:35Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-10-06T22:01:35Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

pcc · 2022-10-06T22:01:41Z

cc @chriswailes

the8472 · 2022-10-07T08:24:25Z

Newer versions of Android forbid the creation of hardlinks as well as Unix domain sockets in the /data filesystem

Can we find another fs to test on instead? E.g. /tmp?

pcc · 2022-10-07T16:21:54Z

Unfortunately Android devices do not have a filesystem mounted at /tmp. /data is AFAIK pretty much the only filesystem that we can rely on to be present and writable as the shell user (which adb shell commands run as).

m-ou-se · 2022-10-11T09:25:59Z

An issue with this is that we no longer know which tests are actually run and which are skipped on Android. Maybe we should explicitly check for the android version to decide whether a test should be skipped? Or just #[ignore] the tests on Android entirely?

pcc · 2022-10-12T21:06:54Z

An issue with this is that we no longer know which tests are actually run and which are skipped on Android. Maybe we should explicitly check for the android version to decide whether a test should be skipped? Or just #[ignore] the tests on Android entirely?

I'm not sure if it's as simple as checking the Android version (I'm not sure when these restrictions were added and it might not have been at the same time on every device). Applications wouldn't be able to use these APIs successfully so there's less value in testing them, but on the other hand Rust is increasingly being used in the operating system itself. If we don't care that much about whether these tests pass on Android and we expect the existing testing on non-Android Linux to be sufficient then yes, the simplest approach is to ignore them on Android, and I've updated the patch to do that. For the operating system use case we may consider arranging to run these tests only on rooted devices, but that can come later.

pcc · 2022-12-10T01:48:22Z

Anything else needed here? As I mentioned, the tests are now ignored on Android.

pcc · 2023-01-23T22:45:27Z

Ping.

the8472 · 2023-01-23T22:52:15Z

@rustbot ready

bors · 2023-03-02T05:37:33Z

☔ The latest upstream changes (presumably #106673) made this pull request unmergeable. Please resolve the merge conflicts.

Newer versions of Android forbid the creation of hardlinks as well as Unix domain sockets in the /data filesystem via SELinux rules, which causes several tests depending on this behavior to fail. So let's skip these tests on Android with an #[ignore] directive.

pcc · 2023-03-03T00:41:57Z

Ping.

ChrisDenton · 2023-03-26T12:02:23Z

It seems somewhat unfortunate to be ignoring the tests entirely but...

Applications wouldn't be able to use these APIs successfully so there's less value in testing them, but on the other hand Rust is increasingly being used in the operating system itself... For the operating system use case we may consider arranging to run these tests only on rooted devices, but that can come later.

Fair enough. And ignored tests can be run explicitly. I wonder though if there could be some way for the tests to be opt-in as a group? I'm thinking something like:

#[cfg_attr(all(target_os = "android", not(test_rooted_android_device)), ignore)]

Or some other --cfg that can be passed in using rustflags. I'm not sure of the name.

pcc · 2023-04-22T02:12:12Z

What I had in mind for later was that the tests could opt in automatically by checking for getuid() == 0 and skipping if false. That way, we don't end up adding a developer-facing --cfg that we'd just remove again a few months later. Choosing the right thing to do here may take some discussion.

I do think though that as a first step we should make these tests stop failing on Android, since after several months it's already getting rather tedious to need to patch this in every time I need to run the tests.

workingjubilee · 2023-07-26T03:07:54Z

Extremely annoying but at the same time seems fine to me.
r? @workingjubilee
@bors r+

bors · 2023-07-26T03:07:56Z

📌 Commit fed6fce has been approved by workingjubilee

It is now in the queue for this repository.

…bilee Make std tests pass on newer Android Newer versions of Android forbid the creation of hardlinks as well as Unix domain sockets in the /data filesystem via SELinux rules, which causes several tests depending on this behavior to fail. So let's skip these tests on Android if we see an EACCES from one of these syscalls. To achieve this, introduce a macro with the horrible name of or_panic_or_skip_on_android_eacces (better suggestions welcome) which skips (returns from) the test if an EACCES return value is seen on Android.

bors · 2023-07-26T07:57:36Z

⌛ Testing commit fed6fce with merge a6236fa...

bors · 2023-07-26T09:46:17Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing a6236fa to master...

rust-timer · 2023-07-26T13:33:24Z

Finished benchmarking commit (a6236fa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-3.7%, -3.6%]	2
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.76s -> 652.439s (0.26%)

rust-highfive assigned m-ou-se Oct 6, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 6, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2022

This comment has been minimized.

Sign in to view

pcc force-pushed the android-std-tests branch from dc41a8f to d157986 Compare October 6, 2022 23:46

m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2022

pcc force-pushed the android-std-tests branch from d157986 to 77da13a Compare October 12, 2022 20:48

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 23, 2023

pcc force-pushed the android-std-tests branch from 77da13a to fed6fce Compare March 3, 2023 00:41

pcc mentioned this pull request Mar 8, 2023

Improve android-ndk property interface #102994

Closed

rustbot assigned workingjubilee Jul 26, 2023

rustbot unassigned m-ou-se Jul 26, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2023

workingjubilee mentioned this pull request Jul 26, 2023

Rollup of 4 pull requests #114083

Closed

matthiaskrgr mentioned this pull request Jul 26, 2023

Rollup of 5 pull requests #114084

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 26, 2023

bors merged commit a6236fa into rust-lang:master Jul 26, 2023

rustbot added this to the 1.73.0 milestone Jul 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make std tests pass on newer Android #102757

Make std tests pass on newer Android #102757

pcc commented Oct 6, 2022

rust-highfive commented Oct 6, 2022

rustbot commented Oct 6, 2022

pcc commented Oct 6, 2022

This comment has been minimized.

the8472 commented Oct 7, 2022

pcc commented Oct 7, 2022

m-ou-se commented Oct 11, 2022

pcc commented Oct 12, 2022

pcc commented Dec 10, 2022

pcc commented Jan 23, 2023

the8472 commented Jan 23, 2023

bors commented Mar 2, 2023

pcc commented Mar 3, 2023

ChrisDenton commented Mar 26, 2023

pcc commented Apr 22, 2023

workingjubilee commented Jul 26, 2023

bors commented Jul 26, 2023

bors commented Jul 26, 2023

bors commented Jul 26, 2023

rust-timer commented Jul 26, 2023

Make std tests pass on newer Android #102757

Make std tests pass on newer Android #102757

Conversation

pcc commented Oct 6, 2022

rust-highfive commented Oct 6, 2022

rustbot commented Oct 6, 2022

pcc commented Oct 6, 2022

This comment has been minimized.

the8472 commented Oct 7, 2022

pcc commented Oct 7, 2022

m-ou-se commented Oct 11, 2022

pcc commented Oct 12, 2022

pcc commented Dec 10, 2022

pcc commented Jan 23, 2023

the8472 commented Jan 23, 2023

bors commented Mar 2, 2023

pcc commented Mar 3, 2023

ChrisDenton commented Mar 26, 2023

pcc commented Apr 22, 2023

workingjubilee commented Jul 26, 2023

bors commented Jul 26, 2023

bors commented Jul 26, 2023

bors commented Jul 26, 2023

rust-timer commented Jul 26, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size