Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: stop iOS from coloring the sidebar menu button blue #102564

Closed
wants to merge 1 commit into from
Closed

rustdoc: stop iOS from coloring the sidebar menu button blue #102564

wants to merge 1 commit into from

Conversation

notriddle
Copy link
Contributor

No description provided.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 2, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2022
@GuillaumeGomez
Copy link
Member

The CSS looks good to me but I'll let @jsha checks with their iPhone to confirm it's working as expected.

@bors
Copy link
Contributor

bors commented Oct 5, 2022

☔ The latest upstream changes (presumably #102704) made this pull request unmergeable. Please resolve the merge conflicts.

@notriddle notriddle closed this Oct 6, 2022
@notriddle notriddle deleted the notriddle/ios branch October 6, 2022 02:41
@notriddle
Copy link
Contributor Author

#102699 accomplished the same thing

@GuillaumeGomez
Copy link
Member

Oh ok. Completely unexpected side-effect. ^^'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@CraftSpider CraftSpider

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@notriddle @rust-highfive @rustbot @GuillaumeGomez @bors @CraftSpider