Skip to content

Stabilize the instruction_set feature #102458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2022
Merged

Stabilize the instruction_set feature #102458

merged 1 commit into from
Nov 5, 2022

Conversation

JohnTitor
Copy link
Member

Closes #74727
FCP is complete on #74727 (comment)
r? @pnkfelix and/or @nikomatsakis
cc @xd009642

Signed-off-by: Yuki Okushi jtitor@2k36.org

@JohnTitor
Stabilize the instruction_set feature
7874976 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 29, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2022
@xd009642 xd009642 mentioned this pull request Nov 5, 2022
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Nov 5, 2022

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned pnkfelix Nov 5, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Nov 5, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 5, 2022

📌 Commit 7874976 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2022
@bors
Copy link
Collaborator

bors commented Nov 5, 2022

⌛ Testing commit 7874976 with merge 1286ee2...

@bors
Copy link
Collaborator

bors commented Nov 5, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 1286ee2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2022
@bors bors merged commit 1286ee2 into rust-lang:master Nov 5, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 5, 2022
@JohnTitor JohnTitor deleted the stabilize-instruction-set branch November 6, 2022 00:26
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1286ee2): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.3% [0.7%, 1.9%] 9
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.4% [-3.4%, -3.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.8% [-3.4%, 1.9%] 10

Cycles

This benchmark run did not return any relevant results for this metric.

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#102458 - JohnTitor:stabilize-instruction-set,…
c5af5c4 
… r=oli-obk

Stabilize the `instruction_set` feature

Closes rust-lang#74727
FCP is complete on rust-lang#74727 (comment)
r? `@pnkfelix` and/or `@nikomatsakis`
cc `@xd009642`

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 21, 2023
Closed
@Jules-Bertholet Jules-Bertholet mentioned this pull request Dec 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for #[instruction_set] attribute (RFC 2867)
7 participants
@JohnTitor @oli-obk @bors @rust-timer @pnkfelix @rust-highfive @rustbot