remove outdated coherence hack

[lcnr]

we have a more precise detection for downstream conflicts in candidate assembly: the is_knowable check in candidate_from_obligation_no_cache.

r? types cc @nikomatsakis

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit d358f2c6d91c578c139bfab3e5693d16eac4235e with merge de7eef084f15b741b9b5b084d96b271da330ea4a...

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 932f930 with merge efb6aaee82be7ecd0878e187518d56ce7887d6b3...

[bors]

☀️ Try build successful - checks-actions
Build commit: efb6aaee82be7ecd0878e187518d56ce7887d6b3 (efb6aaee82be7ecd0878e187518d56ce7887d6b3)

[rust-timer]

Queued efb6aaee82be7ecd0878e187518d56ce7887d6b3 with parent 72f4923, future comparison URL.

[rust-timer]

Finished benchmarking commit (efb6aaee82be7ecd0878e187518d56ce7887d6b3): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-4.3%, -4.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[compiler-errors]

@bors r+

[bors]

📌 Commit 932f930 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 932f930 with merge d45feb3...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing d45feb3 to master...

[rust-timer]

Finished benchmarking commit (d45feb3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.4%, 3.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.1%	[-5.2%, -2.7%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-2.8%	[-3.0%, -2.7%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-3.0%, -2.7%]	2

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²