Remove some unused CSS rules #101898
Merged
Remove some unused CSS rules #101898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha A change occurred in the Ayu theme. cc @Cldfire |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
rm-unused-css
branch
4 times, most recently
from
9db07e0 to
33680dc
Compare
GuillaumeGomez
force-pushed
the
rm-unused-css
branch
from
33680dc to
99c0071
Compare
notriddle
requested changes
Sep 16, 2022
| @@ -119,9 +119,6 @@ pre, .rustdoc.source .example-wrap { | |||
| .content span.traitalias, .content a.traitalias { color: #39AFD7; } | |||
| .content span.keyword, .content a.keyword { color: #39AFD7; } | |||
|
|
|||
| .content span.externcrate, .content span.mod, .content a.mod { | |||
| color: #39AFD7; | |||
| } | |||
There was a problem hiding this comment.
.content a.mod actually has an effect on the page. When I build docs with your branch, it doesn't color in the current module's name any more:
There was a problem hiding this comment.
Same problem applies to the dark and light themes.
There was a problem hiding this comment.
Indeed. Only .externcrate should have been removed. Updating shortly.
GuillaumeGomez
force-pushed
the
rm-unused-css
branch
from
5d36f3e to
785bab8
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
rm-unused-css
branch
from
785bab8 to
28956d1
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 16, 2022
…triddle
Remove some unused CSS rules
Since we now have list of items for the ones on the page, we don't need the CSS rules anymore in the sidebar (`.sidebar a`). As for the `.content` ones, they are used to highlight the items in the page (for definitions and others). Surprisingly enough, `method` and `tymethod` are all replaced with `fnname`.
I also used this opportunity to remove these rules in `ayu.css`:
```css
.stab.unstable {}
h2,
h3:not(.impl):not(.method):not(.type):not(.tymethod), h4:not(.method):not(.type):not(.tymethod) {}
```
In the second commit, I removed the `.block a.current*` CSS rules as they're overridden by `.sidebar a.current*` CSS rules.
In the third commit I removed unneeded empty rules (that were there to satisfy the `--check-theme` option).
cc `@jsha`
r? `@notriddle`
notriddle
approved these changes
Sep 17, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#101340 (Adding Fuchsia zxdb debugging walkthrough to docs) - rust-lang#101741 (Adding needs-unwind arg to applicable compiler ui tests) - rust-lang#101782 (Update `symbol_mangling` diagnostics migration) - rust-lang#101878 (More simple formatting) - rust-lang#101898 (Remove some unused CSS rules) - rust-lang#101911 (rustdoc: remove no-op CSS on `.source .content`) - rust-lang#101914 (rustdoc-json-types: Document that ResolvedPath can also be a union) - rust-lang#101921 (Pass --cfg=bootstrap for rustdoc for proc_macro crates) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 17, 2022
…, r=notriddle Continue migration of CSS themes Now that rust-lang#101898 has been merged, we can move forward. This PR moves more CSS theme rules as CSS variables. I also added a GUI test to prevent regressions. Part of rust-lang#98460. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 17, 2022
…, r=notriddle Continue migration of CSS themes Now that rust-lang#101898 has been merged, we can move forward. This PR moves more CSS theme rules as CSS variables. I also added a GUI test to prevent regressions. Part of rust-lang#98460. r? ``@notriddle``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now have list of items for the ones on the page, we don't need the CSS rules anymore in the sidebar (
.sidebar a). As for the.contentones, they are used to highlight the items in the page (for definitions and others). Surprisingly enough,methodandtymethodare all replaced withfnname.I also used this opportunity to remove these rules in
ayu.css:In the second commit, I removed the
.block a.current*CSS rules as they're overridden by.sidebar a.current*CSS rules.In the third commit I removed unneeded empty rules (that were there to satisfy the
--check-themeoption).cc @jsha
r? @notriddle