Change default level of INVALID_HTML_TAGS to warning and stabilize it #101720

GuillaumeGomez · 2022-09-12T13:04:48Z

Fixes of #67799.

rustbot · 2022-09-12T15:45:27Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

library/alloc/src/sync.rs

library/alloc/src/vec/mod.rs

Nemo157 · 2022-09-12T16:42:59Z

Most of the doc changes seem to basically be a direct revert of #88343

GuillaumeGomez · 2022-09-12T16:44:38Z

Most of the doc changes seem to basically be a direct revert of #88343

Unfortunately yes. It should have been fixed in the doc generation, not like this.

…html-check, r=GuillaumeGomez rustdoc: improve rustdoc HTML suggestions handling of nested generics Based on some poor suggestions produced when stablizing this lint and running it on `manformed-generics.rs` in rust-lang#101720

GuillaumeGomez · 2022-09-12T18:58:04Z

I'll rebase on top of #101731 once merged then integrate the stabilization part of the PR from here then start the FCP.

…html-check, r=GuillaumeGomez rustdoc: improve rustdoc HTML suggestions handling of nested generics Based on some poor suggestions produced when stablizing this lint and running it on `manformed-generics.rs` in rust-lang#101720

GuillaumeGomez · 2022-09-13T10:04:24Z

Stabilization Report

Implementation History

Initial implementation (Unclosed html tag lint #77119).
Expanded to HTML comments (Check html comments #77753).
Added suggestions to turn the unclosed HTML tag into a codeblock (rustdoc: correct unclosed HTML tags as generics #93569).
Fixed the duplicated warnings with the intra-doc link features (rustdoc: resolve intra-doc links when checking HTML #93605).
Set the lint level to warn and stabilize it (Change default level of INVALID_HTML_TAGS to warning and stabilize it #101720)

Summary

This lint warns about unclosed HTML tags and comments. See https://doc.rust-lang.org/nightly/rustdoc/lints.html#invalid_html_tags for more information.

Experience Report

Before this lint was adding, an unclosed HTML tag could lead to broken generated documentation appearance without providing a way for users to know what went wrong.

GuillaumeGomez · 2022-09-13T10:04:59Z

Then let's start the FCP process to hear everyone's opinion about this. I think it should be at warn level by default before the stabilization because after would finally be the same problem as the new warning would appear from nowhere for users.

Nominating for discussion. Also kicking off an FCP: shall we make it a warning before or after stabilization?

@rfcbot merge

rfcbot · 2022-09-13T10:05:01Z

Team member @GuillaumeGomez has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

~~intra-doc link suggestion~~ resolved by Change default level of INVALID_HTML_TAGS to warning and stabilize it #101720 (comment)

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

CraftSpider · 2022-09-14T16:39:04Z

Changing to warn before stabilization seems fine to me, as stable doesn't disallow typing #[allow(rustdoc::invalid_html_tags)]. People getting the warning on nightly-only briefly, then get it on both shortly after, seems reasonable. Either way, I'm for stabilizing the lint.

camelid · 2022-09-14T20:19:54Z

src/test/rustdoc-ui/intra-doc/malformed-generics.stderr

+LL | //! [Vec<Box<T>]
+   |             ^^^
+   |
+   = note: `#[warn(rustdoc::invalid_html_tags)]` on by default


@rfcbot concern intra-doc link suggestion

Hmm, this should be suggesting wrapping the contents of the link with ``. I've seen people writing links like [Vec<T>] before, so we should definitely be giving them a solution to the lint, which is also a better way to write their code.

I added a test case for [Vec<T>], for completeness' sake, but it already worked.

rust/src/test/rustdoc-ui/suggestions/html-as-generics.stderr

Lines 160 to 169 in 1ec92c8

error: unclosed HTML tag `i32`

--> $DIR/html-as-generics.rs:74:14

|

LL | /// This [Vec<i32>] thing!

| ^^^^^

|

help: try marking as source code

|

LL | /// This [`Vec<i32>`] thing!

| + +

It's not suggesting anything here because of the mismatched angle brackets.

camelid · 2022-09-14T20:20:24Z

@rfcbot concern intra-doc link suggestion

See #101720 (comment).

GuillaumeGomez · 2022-09-22T11:16:59Z

@camelid Did this comment answer your concern?

rustbot · 2022-10-10T16:29:41Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

notriddle · 2022-10-10T16:56:54Z

@bors r+

bors · 2022-10-10T16:56:56Z

📌 Commit 14de94a has been approved by notriddle

It is now in the queue for this repository.

bors · 2022-10-10T18:14:52Z

⌛ Testing commit 14de94a with merge 062de58b6ed12dd1f9bedbfed96ffa5a4e5db1ef...

bors · 2022-10-10T18:42:33Z

💔 Test failed - checks-actions

rustbot · 2022-10-10T18:45:21Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

notriddle · 2022-10-10T18:45:55Z

@bors r+

bors · 2022-10-10T18:45:56Z

📌 Commit d565200 has been approved by notriddle

It is now in the queue for this repository.

bors · 2022-10-10T21:41:05Z

⌛ Testing commit d565200 with merge 36c8e29...

bors · 2022-10-11T00:36:19Z

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 36c8e29 to master...

rust-timer · 2022-10-11T01:59:19Z

Finished benchmarking commit (36c8e29): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[2.7%, 4.0%]	2
Improvements ✅ (primary)	-3.2%	[-4.6%, -2.1%]	3
Improvements ✅ (secondary)	-2.5%	[-3.3%, -1.3%]	26
All ❌✅ (primary)	-3.2%	[-4.6%, -2.1%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	3.2%	[2.2%, 4.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

Perform a bunch of pkglint cleanup while here, and bump bootstrap kits to 1.65.0. Version 1.66.0 (2022-12-15) ========================== Language -------- - [Permit specifying explicit discriminants on all `repr(Int)` enums](rust-lang/rust#95710) ```rust #[repr(u8)] enum Foo { A(u8) = 0, B(i8) = 1, C(bool) = 42, } ``` - [Allow transmutes between the same type differing only in lifetimes](rust-lang/rust#101520) - [Change constant evaluation errors from a deny-by-default lint to a hard error](rust-lang/rust#102091) - [Trigger `must_use` on `impl Trait` for supertraits](rust-lang/rust#102287) This makes `impl ExactSizeIterator` respect the existing `#[must_use]` annotation on `Iterator`. - [Allow `..X` and `..=X` in patterns](rust-lang/rust#102275) - [Uplift `clippy::for_loops_over_fallibles` lint into rustc](rust-lang/rust#99696) - [Stabilize `sym` operands in inline assembly](rust-lang/rust#103168) - [Update to Unicode 15](rust-lang/rust#101912) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. Compiler -------- - [Add armv5te-none-eabi and thumbv5te-none-eabi tier 3 targets](rust-lang/rust#101329) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. - [Add support for linking against macOS universal libraries](rust-lang/rust#98736) Libraries --------- - [Fix `#[derive(Default)]` on a generic `#[default]` enum adding unnecessary `Default` bounds](rust-lang/rust#101040) - [Update to Unicode 15](rust-lang/rust#101821) Stabilized APIs --------------- - [`proc_macro::Span::source_text`](https://doc.rust-lang.org/stable/proc_macro/struct.Span.html#method.source_text) - [`uX::{checked_add_signed, overflowing_add_signed, saturating_add_signed, wrapping_add_signed}`](https://doc.rust-lang.org/stable/std/primitive.u8.html#method.checked_add_signed) - [`iX::{checked_add_unsigned, overflowing_add_unsigned, saturating_add_unsigned, wrapping_add_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_add_unsigned) - [`iX::{checked_sub_unsigned, overflowing_sub_unsigned, saturating_sub_unsigned, wrapping_sub_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_sub_unsigned) - [`BTreeSet::{first, last, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeSet.html#method.first) - [`BTreeMap::{first_key_value, last_key_value, first_entry, last_entry, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeMap.html#method.first_key_value) - [Add `AsFd` implementations for stdio lock types on WASI.](rust-lang/rust#101768) - [`impl TryFrom<Vec<T>> for Box<[T; N]>`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#impl-TryFrom%3CVec%3CT%2C%20Global%3E%3E-for-Box%3C%5BT%3B%20N%5D%2C%20Global%3E) - [`core::hint::black_box`](https://doc.rust-lang.org/stable/std/hint/fn.black_box.html) - [`Duration::try_from_secs_{f32,f64}`](https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.try_from_secs_f32) - [`Option::unzip`](https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.unzip) - [`std::os::fd`](https://doc.rust-lang.org/stable/std/os/fd/index.html) Rustdoc ------- - [Add Rustdoc warning for invalid HTML tags in the documentation](rust-lang/rust#101720) Cargo ----- - [Added `cargo remove` to remove dependencies from Cargo.toml](https://doc.rust-lang.org/nightly/cargo/commands/cargo-remove.html) - [`cargo publish` now waits for the new version to be downloadable before exiting](rust-lang/cargo#11062) See [detailed release notes](https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-166-2022-12-15) for more. Compatibility Notes ------------------- - [Only apply `ProceduralMasquerade` hack to older versions of `rental`](rust-lang/rust#94063) - [Don't export `__heap_base` and `__data_end` on wasm32-wasi.](rust-lang/rust#102385) - [Don't export `__wasm_init_memory` on WebAssembly.](rust-lang/rust#102426) - [Only export `__tls_*` on wasm32-unknown-unknown.](rust-lang/rust#102440) - [Don't link to `libresolv` in libstd on Darwin](rust-lang/rust#102766) - [Update libstd's libc to 0.2.135 (to make `libstd` no longer pull in `libiconv.dylib` on Darwin)](rust-lang/rust#103277) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. - [Make `order_dependent_trait_objects` show up in future-breakage reports](rust-lang/rust#102635) - [Change std::process::Command spawning to default to inheriting the parent's signal mask](rust-lang/rust#101077) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Enable BOLT for LLVM compilation](rust-lang/rust#94381) - [Enable LTO for rustc_driver.so](rust-lang/rust#101403)

Pkgsrc changes: * pkglint cleanups, bump bootstrap kits to 1.65.0. * New target: mipsel-unknown-netbsd, for cpu=mips32 with soft-float. * Managed to retain the build of aarch64_be, llvm needed a patch to avoid use of neon instructions in the BE case (llvm doesn't support use of neon in BE mode). Ref. patch to src/llvm-project/llvm/lib/Support/BLAKE3/blake3_impl.h. Also submitted upstream of LLVM to the BLAKE3 maintainers. * The minimum gcc version is now 7.x, and that includes the cross-compiler for the targets. For i386 this also needs to /usr/include/gcc-7 include files in the target root, because immintrin.h from gcc 5 is not compatible with gcc 7.x. This applies for the targets where we build against a root from netbsd-8 (sparc64, powerpc, i386), and files/gcc-wrap gets a hack for this. * Pick up tweak for -latomic inclusion from rust-lang/rust#104220 and rust-lang/rust#104572 * Retain ability to do 32-bit NetBSD, by changing from 64 to 32 bit types in library/std/src/sys/unix/thread_parker/netbsd.rs. * I've tried to get the "openssl-src" build with -latomic where it's needed. I've introduced the "NetBSD-generic32" system type and use it for the NetBSD mipsel target. There is another attempt to do the same in the patch to vendor/openssl-sys/build/main.rs. Upstream changes: Version 1.66.1 (2023-01-10) =========================== - Added validation of SSH host keys for git URLs in Cargo ([CVE-2022-46176](https://www.cve.org/CVERecord?id=CVE-2022-46176)) Version 1.66.0 (2022-12-15) =========================== Language -------- - [Permit specifying explicit discriminants on all `repr(Int)` enums](rust-lang/rust#95710) ```rust #[repr(u8)] enum Foo { A(u8) = 0, B(i8) = 1, C(bool) = 42, } ``` - [Allow transmutes between the same type differing only in lifetimes](rust-lang/rust#101520) - [Change constant evaluation errors from a deny-by-default lint to a hard error](rust-lang/rust#102091) - [Trigger `must_use` on `impl Trait` for supertraits](rust-lang/rust#102287) This makes `impl ExactSizeIterator` respect the existing `#[must_use]` annotation on `Iterator`. - [Allow `..X` and `..=X` in patterns](rust-lang/rust#102275) - [Uplift `clippy::for_loops_over_fallibles` lint into rustc](rust-lang/rust#99696) - [Stabilize `sym` operands in inline assembly](rust-lang/rust#103168) - [Update to Unicode 15](rust-lang/rust#101912) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. Compiler -------- - [Add armv5te-none-eabi and thumbv5te-none-eabi tier 3 targets](rust-lang/rust#101329) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. - [Add support for linking against macOS universal libraries](rust-lang/rust#98736) Libraries --------- - [Fix `#[derive(Default)]` on a generic `#[default]` enum adding unnecessary `Default` bounds](rust-lang/rust#101040) - [Update to Unicode 15](rust-lang/rust#101821) Stabilized APIs --------------- - [`proc_macro::Span::source_text`](https://doc.rust-lang.org/stable/proc_macro/struct.Span.html#method.source_text) - [`uX::{checked_add_signed, overflowing_add_signed, saturating_add_signed, wrapping_add_signed}`](https://doc.rust-lang.org/stable/std/primitive.u8.html#method.checked_add_signed) - [`iX::{checked_add_unsigned, overflowing_add_unsigned, saturating_add_unsigned, wrapping_add_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_add_unsigned) - [`iX::{checked_sub_unsigned, overflowing_sub_unsigned, saturating_sub_unsigned, wrapping_sub_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_sub_unsigned) - [`BTreeSet::{first, last, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeSet.html#method.first) - [`BTreeMap::{first_key_value, last_key_value, first_entry, last_entry, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeMap.html#method.first_key_value) - [Add `AsFd` implementations for stdio lock types on WASI.](rust-lang/rust#101768) - [`impl TryFrom<Vec<T>> for Box<[T; N]>`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#impl-TryFrom%3CVec%3CT%2C%20Global%3E%3E-for-Box%3C%5BT%3B%20N%5D%2C%20Global%3E) - [`core::hint::black_box`](https://doc.rust-lang.org/stable/std/hint/fn.black_box.html) - [`Duration::try_from_secs_{f32,f64}`](https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.try_from_secs_f32) - [`Option::unzip`](https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.unzip) - [`std::os::fd`](https://doc.rust-lang.org/stable/std/os/fd/index.html) Rustdoc ------- - [Add Rustdoc warning for invalid HTML tags in the documentation](rust-lang/rust#101720) Cargo ----- - [Added `cargo remove` to remove dependencies from Cargo.toml](https://doc.rust-lang.org/nightly/cargo/commands/cargo-remove.html) - [`cargo publish` now waits for the new version to be downloadable before exiting](rust-lang/cargo#11062) See [detailed release notes](https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-166-2022-12-15) for more. Compatibility Notes ------------------- - [Only apply `ProceduralMasquerade` hack to older versions of `rental`](rust-lang/rust#94063) - [Don't export `__heap_base` and `__data_end` on wasm32-wasi.](rust-lang/rust#102385) - [Don't export `__wasm_init_memory` on WebAssembly.](rust-lang/rust#102426) - [Only export `__tls_*` on wasm32-unknown-unknown.](rust-lang/rust#102440) - [Don't link to `libresolv` in libstd on Darwin](rust-lang/rust#102766) - [Update libstd's libc to 0.2.135 (to make `libstd` no longer pull in `libiconv.dylib` on Darwin)](rust-lang/rust#103277) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. - [Make `order_dependent_trait_objects` show up in future-breakage reports](rust-lang/rust#102635) - [Change std::process::Command spawning to default to inheriting the parent's signal mask](rust-lang/rust#101077) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Enable BOLT for LLVM compilation](rust-lang/rust#94381) - [Enable LTO for rustc_driver.so](rust-lang/rust#101403) Version 1.65.0 (2022-11-03) ========================== Language -------- - [Error on `as` casts of enums with `#[non_exhaustive]` variants] (rust-lang/rust#92744) - [Stabilize `let else`](rust-lang/rust#93628) - [Stabilize generic associated types (GATs)] (rust-lang/rust#96709) - [Add lints `let_underscore_drop`, `let_underscore_lock`, and `let_underscore_must_use` from Clippy] (rust-lang/rust#97739) - [Stabilize `break`ing from arbitrary labeled blocks ("label-break-value")] (rust-lang/rust#99332) - [Uninitialized integers, floats, and raw pointers are now considered immediate UB](rust-lang/rust#98919). Usage of `MaybeUninit` is the correct way to work with uninitialized memory. - [Stabilize raw-dylib for Windows x86_64, aarch64, and thumbv7a] (rust-lang/rust#99916) - [Do not allow `Drop` impl on foreign ADTs] (rust-lang/rust#99576) Compiler -------- - [Stabilize -Csplit-debuginfo on Linux] (rust-lang/rust#98051) - [Use niche-filling optimization even when multiple variants have data] (rust-lang/rust#94075) - [Associated type projections are now verified to be well-formed prior to resolving the underlying type] (rust-lang/rust#99217) - [Stringify non-shorthand visibility correctly] (rust-lang/rust#100350) - [Normalize struct field types when unsizing] (rust-lang/rust#101831) - [Update to LLVM 15](rust-lang/rust#99464) - [Fix aarch64 call abi to correctly zeroext when needed] (rust-lang/rust#97800) - [debuginfo: Generalize C++-like encoding for enums] (rust-lang/rust#98393) - [Add `special_module_name` lint] (rust-lang/rust#94467) - [Add support for generating unique profraw files by default when using `-C instrument-coverage`] (rust-lang/rust#100384) - [Allow dynamic linking for iOS/tvOS targets] (rust-lang/rust#100636) New targets: - [Add armv4t-none-eabi as a tier 3 target] (rust-lang/rust#100244) - [Add powerpc64-unknown-openbsd and riscv64-unknown-openbsd as tier 3 targets] (rust-lang/rust#101025) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Don't generate `PartialEq::ne` in derive(PartialEq)] (rust-lang/rust#98655) - [Windows RNG: Use `BCRYPT_RNG_ALG_HANDLE` by default] (rust-lang/rust#101325) - [Forbid mixing `System` with direct system allocator calls] (rust-lang/rust#101394) - [Document no support for writing to non-blocking stdio/stderr] (rust-lang/rust#101416) - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`](rust-lang/rust#95295) This also changes the safety conditions on `Layout::from_size_align_unchecked`. Stabilized APIs --------------- - [`std::backtrace::Backtrace`] (https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html) - [`Bound::as_ref`] (https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#method.as_ref) - [`std::io::read_to_string`] (https://doc.rust-lang.org/stable/std/io/fn.read_to_string.html) - [`<*const T>::cast_mut`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_mut) - [`<*mut T>::cast_const`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_const) These APIs are now stable in const contexts: - [`<*const T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) - [`<*mut T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) Cargo ----- - [Apply GitHub fast path even for partial hashes] (rust-lang/cargo#10807) - [Do not add home bin path to PATH if it's already there] (rust-lang/cargo#11023) - [Take priority into account within the pending queue] (rust-lang/cargo#11032). This slightly optimizes job scheduling by Cargo, with typically small improvements on larger crate graph builds. Compatibility Notes ------------------- - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`] (rust-lang/rust#95295). This also changes the safety conditions on `Layout::from_size_align_unchecked`. - [`PollFn` now only implements `Unpin` if the closure is `Unpin`] (rust-lang/rust#102737). This is a possible breaking change if users were relying on the blanket unpin implementation. See discussion on the PR for details of why this change was made. - [Drop ExactSizeIterator impl from std::char::EscapeAscii] (rust-lang/rust#99880) This is a backwards-incompatible change to the standard library's surface area, but is unlikely to affect real world usage. - [Do not consider a single repeated lifetime eligible for elision in the return type] (rust-lang/rust#103450) This behavior was unintentionally changed in 1.64.0, and this release reverts that change by making this an error again. - [Reenable disabled early syntax gates as future-incompatibility lints] (rust-lang/rust#99935) - [Update the minimum external LLVM to 13] (rust-lang/rust#100460) - [Don't duplicate file descriptors into stdio fds] (rust-lang/rust#101426) - [Sunset RLS](rust-lang/rust#100863) - [Deny usage of `#![cfg_attr(..., crate_type = ...)]` to set the crate type] (rust-lang/rust#99784) This strengthens the forward compatibility lint deprecated_cfg_attr_crate_type_name to deny. - [`llvm-has-rust-patches` allows setting the build system to treat the LLVM as having Rust-specific patches] (rust-lang/rust#101072) This option may need to be set for distributions that are building Rust with a patched LLVM via `llvm-config`, not the built-in LLVM. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add `x.sh` and `x.ps1` shell scripts] (rust-lang/rust#99992) - [compiletest: use target cfg instead of hard-coded tables] (rust-lang/rust#100260) - [Use object instead of LLVM for reading bitcode from rlibs] (rust-lang/rust#98100) - [Enable MIR inlining for optimized compilations] (rust-lang/rust#91743) This provides a 3-10% improvement in compiletimes for real world crates. See [perf results] (https://perf.rust-lang.org/compare.html?start=aedf78e56b2279cc869962feac5153b6ba7001ed&end=0075bb4fad68e64b6d1be06bf2db366c30bc75e1&stat=instructions:u).

rust-highfive assigned notriddle Sep 12, 2022

rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 12, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2022

GuillaumeGomez mentioned this pull request Sep 12, 2022

Tracking issue for check_invalid_html_tags #67799

Closed

5 tasks

GuillaumeGomez force-pushed the warn-INVALID_HTML_TAGS branch 2 times, most recently from 232a1c7 to 08ebd4f Compare September 12, 2022 15:45

GuillaumeGomez force-pushed the warn-INVALID_HTML_TAGS branch from 08ebd4f to 79bbd1c Compare September 12, 2022 15:50

Nemo157 reviewed Sep 12, 2022

View reviewed changes

library/alloc/src/sync.rs Outdated Show resolved Hide resolved

Nemo157 reviewed Sep 12, 2022

View reviewed changes

library/alloc/src/vec/mod.rs Outdated Show resolved Hide resolved

notriddle mentioned this pull request Sep 12, 2022

rustdoc: improve rustdoc HTML suggestions handling of nested generics #101731

Merged

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the warn-INVALID_HTML_TAGS branch from 79bbd1c to d94fbb5 Compare September 13, 2022 10:03

GuillaumeGomez changed the title ~~Change default lint level of INVALID_HTML_TAGS to warning~~ Change default level of INVALID_HTML_TAGS to warning and stabilize it Sep 13, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 13, 2022

GuillaumeGomez force-pushed the warn-INVALID_HTML_TAGS branch from d94fbb5 to f92d294 Compare September 13, 2022 11:43

camelid reviewed Sep 14, 2022

View reviewed changes

Fix unclosed HTML tag in rustfmt doc

14de94a

GuillaumeGomez force-pushed the warn-INVALID_HTML_TAGS branch from a01eb1c to 14de94a Compare October 10, 2022 16:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2022

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2022

Fix unclosed HTML tag in clippy doc

d565200

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2022

This comment was marked as outdated.

Sign in to view

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 11, 2022

bors merged commit 36c8e29 into rust-lang:master Oct 11, 2022

rustbot added this to the 1.66.0 milestone Oct 11, 2022

GuillaumeGomez deleted the warn-INVALID_HTML_TAGS branch October 11, 2022 09:00

apiraino removed the to-announce Announce this issue on triage meeting label Oct 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change default level of INVALID_HTML_TAGS to warning and stabilize it #101720

Change default level of INVALID_HTML_TAGS to warning and stabilize it #101720

GuillaumeGomez commented Sep 12, 2022 •

edited

Loading

rustbot commented Sep 12, 2022

Nemo157 commented Sep 12, 2022

GuillaumeGomez commented Sep 12, 2022

GuillaumeGomez commented Sep 12, 2022

This comment has been minimized.

GuillaumeGomez commented Sep 13, 2022

GuillaumeGomez commented Sep 13, 2022

rfcbot commented Sep 13, 2022 •

edited

Loading

CraftSpider commented Sep 14, 2022

camelid Sep 14, 2022 •

edited

Loading

notriddle Sep 14, 2022 •

edited

Loading

camelid commented Sep 14, 2022

GuillaumeGomez commented Sep 22, 2022

rustbot commented Oct 10, 2022

notriddle commented Oct 10, 2022

bors commented Oct 10, 2022

This comment has been minimized.

bors commented Oct 10, 2022

bors commented Oct 10, 2022

rustbot commented Oct 10, 2022

notriddle commented Oct 10, 2022

bors commented Oct 10, 2022

This comment was marked as outdated.

bors commented Oct 10, 2022

bors commented Oct 11, 2022

rust-timer commented Oct 11, 2022

	error: unclosed HTML tag `i32`
	--> $DIR/html-as-generics.rs:74:14
	\|
	LL \| /// This [Vec<i32>] thing!
	\| ^^^^^
	\|
	help: try marking as source code
	\|
	LL \| /// This [`Vec<i32>`] thing!
	\| + +

Change default level of INVALID_HTML_TAGS to warning and stabilize it #101720

Change default level of INVALID_HTML_TAGS to warning and stabilize it #101720

Conversation

GuillaumeGomez commented Sep 12, 2022 • edited Loading

rustbot commented Sep 12, 2022

Nemo157 commented Sep 12, 2022

GuillaumeGomez commented Sep 12, 2022

GuillaumeGomez commented Sep 12, 2022

This comment has been minimized.

GuillaumeGomez commented Sep 13, 2022

Stabilization Report

Implementation History

Summary

Experience Report

GuillaumeGomez commented Sep 13, 2022

rfcbot commented Sep 13, 2022 • edited Loading

CraftSpider commented Sep 14, 2022

camelid Sep 14, 2022 • edited Loading

Choose a reason for hiding this comment

notriddle Sep 14, 2022 • edited Loading

Choose a reason for hiding this comment

camelid commented Sep 14, 2022

GuillaumeGomez commented Sep 22, 2022

rustbot commented Oct 10, 2022

notriddle commented Oct 10, 2022

bors commented Oct 10, 2022

This comment has been minimized.

bors commented Oct 10, 2022

bors commented Oct 10, 2022

rustbot commented Oct 10, 2022

notriddle commented Oct 10, 2022

bors commented Oct 10, 2022

This comment was marked as outdated.

bors commented Oct 10, 2022

bors commented Oct 11, 2022

rust-timer commented Oct 11, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

GuillaumeGomez commented Sep 12, 2022 •

edited

Loading

rfcbot commented Sep 13, 2022 •

edited

Loading

camelid Sep 14, 2022 •

edited

Loading

notriddle Sep 14, 2022 •

edited

Loading