Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustc's information on Android's sanitizers #101598

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

chriswailes
Copy link
Contributor

@chriswailes chriswailes commented Sep 9, 2022

This patch updates sanitizer support definitions for Android inside the compiler. It also adjusts the logic to make sure no pre-built sanitizer runtime libraries are emitted as these are instead provided dynamically on Android targets.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 9, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TaKO8Ki (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2022
@rust-log-analyzer

This comment has been minimized.

@chriswailes chriswailes force-pushed the sanitizers branch 2 times, most recently from 4cd76f6 to 6f2b1ec Compare September 9, 2022 21:32
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Sep 12, 2022

I'd prefer to re-roll. r? compiler

@jyn514
Copy link
Member

jyn514 commented Sep 14, 2022

r? @nagisa cc @petrochenkov

@jyn514 jyn514 added the A-target-specs Area: Compile-target specifications label Sep 14, 2022
This patch updates sanitizier support definitions for Android inside the
compiler.  It also adjusts the logic to make sure no pre-built sanitizer
runtime libraries are emitted as these are instead provided dynamically
on Android targets.
@nagisa
Copy link
Member

nagisa commented Sep 22, 2022

@bors r=nagisa,eholk

Thanks!

@bors
Copy link
Contributor

bors commented Sep 22, 2022

📌 Commit 3d5a417 has been approved by nagisa,eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101598 (Update rustc's information on Android's sanitizers)
 - rust-lang#102036 (Remove use of `io::ErrorKind::Other` in std)
 - rust-lang#102037 (Make cycle errors recoverable)
 - rust-lang#102069 (Skip `Equate` relation in `handle_opaque_type`)
 - rust-lang#102076 (rustc_transmute: fix big-endian discriminants)
 - rust-lang#102107 (Add missing space between notable trait tooltip and where clause)
 - rust-lang#102119 (Fix a typo “pararmeter” in error message)
 - rust-lang#102131 (Added which number is computed in compute_float.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b36a10a into rust-lang:master Sep 22, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-target-specs Area: Compile-target specifications S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants