Show the name of the trait in the error message #10118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ trait foo { | |||
| } | |||
| impl foo for int { | |||
| fn bar(&self) -> int { | |||
| //~^ ERROR method `bar` has 0 parameters but the trait has 1 | |||
| //~^ ERROR method `bar` has 0 parameters but the trait `foo::bar` has 1 | |||
There was a problem hiding this comment.
This seems incorrect. foo::bar is a method declaration, not a trait.
|
Agreed with @cmr. |
|
@jaeminMoon Can you make the change @cmr requested to the message? Thanks for your patience. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 16, 2022
Generate rust type from json fix rust-lang#10118 Should this be a diagnostic? I made it a diagnostic because of issue label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5925.