Track PGO profiles in depinfo

[Kobzol]

This PR makes sure that PGO profiles (-Cprofile-use and -Cprofile-sample-use) are tracked in depinfo, so that when they change, the compilation session will be invalidated.

This approach was discussed on Zulip.

I tried it locally and it seems that the code is recompiled just with this change, and #100413 is not even needed. But it's possible that not everything required is recompiled, so we will probably want to land both changes.

Another approach to implement this could be to store the PGO profiles in sess.parse_sess.file_depinfo when the session is being created, but then the paths would have to be converted to a string and then to a symbol, which seemed unnecessarily complicated.

CC @michaelwoerister

r? @Eh2406

[Eh2406]

Looks reasonable, but I am not a reviewer on the rust repo.

[Kobzol]

r? @michaelwoerister

[michaelwoerister]

Thanks a lot, @Kobzol! Looks good.

@bors r+ rollup=never (I prefer to not rollup PRs that modify run-make tests -- those are too flaky)

[bors]

📌 Commit aec34d6ed5d3ef87b34d4e6323848160f5d97298 has been approved by michaelwoerister

It is now in the queue for this repository.

[bors]

⌛ Testing commit aec34d6ed5d3ef87b34d4e6323848160f5d97298 with merge 71b88e490749a284c99f46df5bad873b27a413c3...

[bors]

💔 Test failed - checks-actions

[Kobzol]

Fixed the MSVC CI failure.

@rustbot ready

[Kobzol]

@michaelwoerister Probably the PR will have to be reapproved.

[michaelwoerister]

@bors r+

[bors]

📌 Commit 925644e has been approved by michaelwoerister

It is now in the queue for this repository.

[bors]

⌛ Testing commit 925644e with merge ff479b1...

[bors]

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing ff479b1 to master...

[rust-timer]

Finished benchmarking commit (ff479b1): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[1.8%, 2.4%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.7%	[2.0%, 3.4%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-3.1%, -2.3%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[-3.1%, 3.4%]	4

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[Kobzol]

PGO is not used when compiling the perf. suite benchmarks and keccak has been bimodal lately, so this is just noise.

@rustbot label: +perf-regression-triaged