Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics migr const eval #100738

Merged
merged 10 commits into from
Aug 27, 2022
Merged

Diagnostics migr const eval #100738

merged 10 commits into from
Aug 27, 2022

Conversation

nidnogg
Copy link
Contributor

@nidnogg nidnogg commented Aug 19, 2022

This PR should eventually contain all diagnostic migrations for the rustc_const_eval crate.

r? @davidtwco
@rustbot label +A-translation

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 19, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2022
@davidtwco
Copy link
Member

r? @compiler-errors

@nidnogg
Copy link
Contributor Author

nidnogg commented Aug 19, 2022

I added in some more migrations but I'm struggling a bit with their test passes - if anyone could give me some pointers that'd be really appreciated!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
Xiretza
Xiretza reviewed Aug 20, 2022
View reviewed changes
Copy link
Contributor

@Xiretza Xiretza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create_feature_err() does not automatically assign error code E0658 like feature_err() does - maybe that should be changed there (with a check that the diagnostic that's passed in does not already have an error code set)?

compiler/rustc_const_eval/src/errors.rs Show resolved Hide resolved
compiler/rustc_const_eval/src/errors.rs Show resolved Hide resolved
@nidnogg nidnogg marked this pull request as ready for review August 20, 2022 22:29
@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nidnogg nidnogg force-pushed the diagnostics_migr_const_eval branch from 63c2f86 to 13abae2 Compare August 22, 2022 03:03
@nidnogg nidnogg requested review from davidtwco and removed request for compiler-errors August 22, 2022 11:54
davidtwco
davidtwco approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me once remaining comments addressed

@nidnogg
Copy link
Contributor Author

nidnogg commented Aug 22, 2022

r? @davidtwco

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 22, 2022

📌 Commit 5101688 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2022
@davidtwco davidtwco mentioned this pull request Aug 23, 2022
Open
84 tasks
@compiler-errors
Copy link
Member

@bors rollup

@compiler-errors compiler-errors mentioned this pull request Aug 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2022
@bors
Auto merge of rust-lang#101064 - compiler-errors:rollup-fwm5m5f, r=co…
bb8a08f 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#100724 (Migrate ast lowering to session diagnostic)
 - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`)
 - rust-lang#100738 (Diagnostics migr const eval)
 - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs)
 - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`)
 - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword)
 - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics)
 - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic)
 - rust-lang#100900 (on `region_errors.rs`)

Failed merges:

 - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b543444 into rust-lang:master Aug 27, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@Xiretza Xiretza Xiretza left review comments

@jeffparsons jeffparsons jeffparsons left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
9 participants
@nidnogg @davidtwco @rust-log-analyzer @rustbot @bors @compiler-errors @jeffparsons @Xiretza @rust-highfive