Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #100346

Merged
merged 37 commits into from
Aug 10, 2022
Merged

Rollup of 14 pull requests #100346

merged 37 commits into from
Aug 10, 2022

Commits on Jul 5, 2022

  1. rustdoc: improve scroll locking in the rustdoc mobile sidebars

    This commit ports the scroll locking behavior from the source sidebar to the
    regular sidebar, and also fixes some bad behavior where opening a "mobile"
    sidebar, and growing the viewport so that the "desktop" mode without scroll
    locking is activated, could potentially leave the page stuck.
    
    This does not affect the behavior on larger screens. Only small ones, where
    the sidebar covers up the main content.
    notriddle committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    6b60bc6 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Configuration menu
    Copy the full SHA
    4e73d90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3dfd268 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1b6f629 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Configuration menu
    Copy the full SHA
    27b9b16 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e1eab53 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Configuration menu
    Copy the full SHA
    9cf5709 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4df6cbe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a3fd50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    603ffeb View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2022

  1. Configuration menu
    Copy the full SHA
    db7ddc5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa031f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Add some high-level docs to FnCtxt and ItemCtxt

    I haven't understood the difference between these before, but
    `@compiler-errors` helped me clear it up. Hopefully this will help other
    people who've been confused!
    camelid committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    1f75142 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92ce2c1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bed8e93 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    daa0e8f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fb8636f View commit details
    Browse the repository at this point in the history
  6. Add test for rust-lang#100246.

    luqmana committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    75cc9cd View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Configuration menu
    Copy the full SHA
    5ed55f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd816a9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c634852 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ae1c03 View commit details
    Browse the repository at this point in the history
  5. Address review comments

    camelid committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    31a0518 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#98775 - notriddle:notriddle/mobile-sidebar-…

    …scroll-lock, r=jsha
    
    rustdoc: improve scroll locking in the rustdoc mobile sidebars
    
    This PR prevents the main content area from scrolling while the mobile sidebar is open on documentation pages (porting the scroll locking behavior from the source sidebar to the regular sidebar), and also fixes some bad behavior where opening a "mobile" sidebar, and growing the viewport so that the "desktop" mode without scroll locking is activated, could potentially leave the page stuck.
    
    This does not affect the behavior on larger screens. Only small ones, where the sidebar covers up the main content.
    
    Split out from rust-lang#98772
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    02fc0fa View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#99479 - Enselic:import-can-be-without-id, r…

    …=camelid
    
    rustdoc-json: Remove doc FIXME for Import::id and explain
    
    Also add some test and refactor related code a bit.
    
    ``@rustbot`` labels +A-rustdoc-json +T-rustdoc
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    0dc39c7 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#100040 - ChrisDenton:broken-pipe, r=davidtwco

    Error on broken pipe but do not backtrace or ICE
    
    Windows will report a broken pipe as a normal error which in turn `println!` will panic on. Currently this causes rustc to produce a backtrace and ICE. However, this is not a bug with rustc so a backtrace is overly verbose and ultimately unhelpful to the user.
    
    Kind of fixes rust-lang#98700. Although this is admittedly a bit of a hack because at panic time all we have is a string to inspect. On zulip it was suggested that libstd might someday provide a way to indicate a soft panic but that day isn't today.
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    cf7a9ae View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#100072 - oToToT:patch-1, r=michaelwoerister

    linker-plugin-lto.md: Correct the name of example c file
    
    The final output is linked with `cmain.o`, but we use `main.o` in the example.
    This patch changes the name to `cmain.c` and `cmain.o` as the "C/C++ code as a dependency in Rust" section.
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    2059391 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#100098 - compiler-errors:field-suggestion-f…

    …ixups, r=davidtwco
    
    Some "this expression has a field"-related fixes
    
    Each commit does something different and is worth reviewing, but the final diff from `master..HEAD` contains the sum of the changes to the UI tests, since some commits added UI tests "regressions" which were later removed in other commits.
    
    The only change I could see adding on top of this is suppressing `Clone::clone` from the "this expression has a field that has this method" suggestion, since it's so commonly implemented by types that it's not worthwhile suggesting in general.
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    867453e View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#100226 - cjgillot:noice-multibyte, r=davidtwco

    Do not manually craft a span pointing inside a multibyte character.
    
    Fixes rust-lang#92462
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    e6c9594 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#100240 - cjgillot:noice-structural-match, r…

    …=davidtwco
    
    Fail gracefully when const pattern is not structural match.
    
    Fixes rust-lang#82909
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b11b8d6 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#100256 - camelid:typeck-ctxt-doc, r=compile…

    …r-errors
    
    Add some high-level docs to `FnCtxt` and `ItemCtxt`
    
    I haven't understood the difference between these before, but
    ``@compiler-errors`` helped me clear it up. Hopefully this will help other
    people who've been confused!
    
    r? `@compiler-errors`
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    4add514 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#100261 - luqmana:suggestions-overflow, r=lcnr

    Set tainted errors bit before emitting coerce suggestions.
    
    Fixes rust-lang#100246.
    
    rust-lang#89576 basically got 99% of the way there but the match typechecking code (which calls `coerce_inner`) also needed a similar fix.
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    2be32e8 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#100275 - RalfJung:anyhow, r=bjorn3

    also update anyhow in codegen_cranelift
    
    now that is has been un-yanked
    r? ``@bjorn3``
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    45c9dde View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#100281 - GuillaumeGomez:rm-clean-impls-3, r…

    …=notriddle
    
    Remove more Clean trait implementations
    
    Follow-up of rust-lang#99638.
    
    r? `@notriddle`
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    790b19f View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#100314 - JakobDegen:test-docs, r=RalfJung

    Mention `unit-test` in MIR opt test README
    
    r? `@RalfJung`
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    e8d8599 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#100319 - GuillaumeGomez:rm-clean-impls-2, r…

    …=Dylan-DPC
    
    Remove more Clean trait implementations
    
    Follow-up of rust-lang#99638.
    
    r? ``@Dylan-DPC``
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    a431ef4 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#100323 - GuillaumeGomez:impl-blocks-only-pr…

    …ivate, r=notriddle
    
    [rustdoc] Don't render impl blocks with doc comment if they only contain private items by default
    
    Fixes rust-lang#100001.
    
    cc `@jhpratt`
    r? `@notriddle`
    matthiaskrgr authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    752b9a8 View commit details
    Browse the repository at this point in the history