Rename integer log* methods to ilog* #100332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects the concensus from the libs team as reported at rust-lang#70887 (comment) Co-authored-by: Yosh Wuyts <github@yosh.is>
rustbot
added
the
T-libs
This comment was marked as resolved.
This comment was marked as resolved.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
It seems this needs to be updated to say rust/src/test/rustdoc-json/primitive.rs Lines 10 to 11 in 6d3f1be |
This comment has been minimized.
This comment has been minimized.
scottmcm
added
T-libs-api
|
The consensus in #70887 (comment) is sufficient libs-api approval for this in nightly, so |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 10, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#99573 (Stabilize backtrace) - rust-lang#100069 (Add error if link_ordinal used with unsupported link kind) - rust-lang#100086 (Add more `// unit-test`s to MIR opt tests) - rust-lang#100332 (Rename integer log* methods to ilog*) - rust-lang#100334 (Suggest a missing semicolon before an array) - rust-lang#100340 (Iterate generics_def_id_map in reverse order to fix P-critical issue) - rust-lang#100345 (docs: remove repetition in `is_numeric` function docs) - rust-lang#100352 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
8 tasks
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 13, 2022
…an-DPC Fix doc of log function Hi. I found a forgotten documentation correction in the following pull request. rust-lang#100332 See also: rust-lang#70887
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 13, 2022
…an-DPC Fix doc of log function Hi. I found a forgotten documentation correction in the following pull request. rust-lang#100332 See also: rust-lang#70887
workingjubilee
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
Sep 15, 2022
Fix doc of log function Hi. I found a forgotten documentation correction in the following pull request. rust-lang/rust#100332 See also: rust-lang/rust#70887
mikegerwitz
pushed a commit
to lovullo/tame
that referenced
this pull request
Nov 11, 2022
rust-lang/rust#100332 The above MR replaces `log10` and friends with `ilog10`; this is the first time an unstable feature bit us in a substantially backwards-incompatible way that's a pain to deal with. Fortunately, I'm just not going to deal with it: this is used with the diagnostic system, which isn't yet used by our projects (outside of me testing), and so those builds shouldn't fail before people upgrade. This is now pending stabalization with the new name, so hopefully we're good now: rust-lang/rust#70887 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects the concensus from the libs team as reported at #70887 (comment).
Joint work with @yoshuawuyts.