Add standard C error function aliases to last_os_error #100296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Aids the discoverability of `io::Error::last_os_error()` by linking to commonly used error number functions from C/C++.
BlackHoleFox
force-pushed
the
os-error-aliases
branch
from
2b315cb to
08c9732
Compare
BlackHoleFox
changed the title
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 28, 2022
…iaskrgr Rollup of 13 pull requests Successful merges: - rust-lang#97015 (std::io: migrate ReadBuf to BorrowBuf/BorrowCursor) - rust-lang#98301 (Add GDB/LLDB pretty-printers for NonZero types) - rust-lang#99570 (Box::from(slice): Clarify that contents are copied) - rust-lang#100296 (Add standard C error function aliases to last_os_error) - rust-lang#100520 (Add mention of `BufReader` in `Read::bytes` docs) - rust-lang#100885 (Export Cancel from std::os::fortanix_sgx::usercalls::raw) - rust-lang#100955 (Some papercuts on error::Error) - rust-lang#101002 (Provide structured suggestion for `hashmap[idx] = val`) - rust-lang#101038 (no alignment check during interning) - rust-lang#101055 (Use smaller span for suggestions) - rust-lang#101091 (Extend attrs if local_def_id exists) - rust-lang#101098 (rustc_middle: Remove `Visibility::Invisible`) - rust-lang#101102 (unstable-book-gen: use std::fs::write) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aids the discoverability of
io::Error::last_os_error()by linking to commonly used error number functions from C/C++.I've seen a few people not realize this exists, so hopefully this helps draw attention to the API to encourage using it over integer error codes.