Use Parser's restrictions instead of let_expr_allowed
#100011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 2, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#99156 (`codegen_fulfill_obligation` expect erased regions) - rust-lang#99293 (only run --all-targets in stage0 for Std) - rust-lang#99779 (Fix item info pos and height) - rust-lang#99994 (Remove `guess_head_span`) - rust-lang#100011 (Use Parser's `restrictions` instead of `let_expr_allowed`) - rust-lang#100017 (kmc-solid: Update `Socket::connect_timeout` to be in line with rust-lang#78802) - rust-lang#100037 (Update rustc man page to match `rustc --help`) - rust-lang#100042 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also means that the
ALLOW_LETflag is reset properly for subexpressions, so we can properly deny things likea && (b && let c = d). Also the parser is a tiny bit smaller now.It doesn't reject all bad
letexpr usages, just a bit more.cc @c410-f3r