Skip to content

rustdoc: search no longer accepts ! as part of query #96399

Closed
@jsha

Description

@jsha

Steps to reproduce:

  1. Visit https://doc.rust-lang.org/nightly/std/string/trait.ToString.html?search=panic!

Expected result:

All versions of panic (that are macros) appear.

Actual result:

Query parse error.

Compare vs stable: https://doc.rust-lang.org/stable/std/string/trait.ToString.html?search=panic!

I think this is just a matter of accepting ! in the eBNF grammar and also the JS-implemented parser.

Note that the results on stable include modules, which arguably they shouldn't. So as an additional feature improvement we might want to recognize ! specially and treat as requiring that the results be macros (or specifically function-like macros?).

Metadata

Metadata

Labels

A-rustdoc-searchArea: Rustdoc's search featureT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions