rustdoc-json-types: Inconsistant spelling of type/ty

[aDotInTheVoid]

We mostly use type_: Type,

rust/src/rustdoc-json-types/lib.rs

Lines 567 to 568 in ed2a69c

	#[serde(rename = "type")]
	pub type_: Type,

But sometimes use ty

rust/src/rustdoc-json-types/lib.rs

Lines 380 to 383 in ed2a69c

	Const {
	ty: Type,
	default: Option<String>,
	},

rust/src/rustdoc-json-types/lib.rs

Lines 388 to 392 in ed2a69c

	pub enum WherePredicate {
	BoundPredicate { ty: Type, bounds: Vec<GenericBound> },
	RegionPredicate { lifetime: String, bounds: Vec<GenericBound> },
	EqPredicate { lhs: Type, rhs: Term },
	}

We should choose one and stick to it. ty is nicer to type (ha), and generaly consistant with compiller internals, but for those who don't know, type_ is much more clear, even if more ugly.

cc @CraftSpider @P1n3appl3 what do you think?

@rustbot modify labels: +A-rustdoc-json +T-rustdoc +C-discussion

[Enselic]

I am strongly in favor of type_, because

• It is consistent with for_, async_, trait_, etc
• Abbreviations has no place in any public API. Clarity is paramount. (I'm sure someone can come up with exceptions, but it is my firm belief that ty is not one of them.)