Skip to content

Firefox crashes on Windows because BCryptGenRandom fails #94098

Closed

Description

Hi, I'm an engineer working for Mozilla on Firefox. We recently noticed we'd been getting crash reports indicating Firefox crashes during env_logger initialization. Upon debugging, we found out it was caused by a failure of BCryptGenRandom, that was introduced by #84096.

Almost all reports are from Windows 7 32-bit. We don't know the reason why BCryptGenRandom failed. Possibly the cryptography settings in the registry was corrupted and the process couldn't find the module.

To mitigate this crash, can you add a fallback logic, using RtlGenRandom if BCryptGenRandom fails for whatever reason. Probably we can limit it to Win7.

Here's the link to the tracking bug in Bugzilla.

https://bugzilla.mozilla.org/show_bug.cgi?id=1754490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.E-help-wantedCall for participation: Help is requested to fix this issue.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.O-windowsOperating system: WindowsT-libsRelevant to the library team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions