Skip to content

rustdoc: clarify theme settings #84539

Closed
@jsha

Description

@jsha

Right now, you can set theme options in two places, the paintbrush icon, and the settings page:

image

It's not clear how these are related. Does one override the other? Also, what is the "system theme"?

I propose that we move the paintbrush icon's functionality into the settings page, and overhaul the settings available there.

GitHub has put a lot of attention into their "dark mode" implementation and might make a good example for verbiage:


image


image


Following that example, the settings page should have a choice between "single theme" and "sync with system", with a single dropdown visible if you pick "single theme," and two dropdowns (for light/dark) visible if you pick "sync with system."

Prior work:

#77213
#79642
#77809
#77213

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-jsArea: Rustdoc's JS front-endC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions