Skip to content

Move coverage tests from run-make-fulldeps to run-make #83830

Closed

Description

I tried to do this recently and it failed. Some things to remember:

  • Search for and replace references to run-make-fulldeps
  • Update path to ../../run-make-fulldeps/tools.mk from just ../tools.mk
  • bootstrap has an explicit reference to fulldeps in test.rs to build RustDemangler and set --rust-demangler-path, which should be changed to support the move to run-make without fulldeps

I forgot about that last one and its possible that was the only issue.

If not, check bootstrap for other fulldeps dependencies, and note that the error I thought I saw had to do with llvm-profdata or llvm-cov. If so, those may require additional special handling in bootstrap or elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions