Skip to content

Track Windows 7 vs. delete-on-close fixes #82677

Open

Description

Rust #82605 reverted LLVM D81803, "Avoid setting the delete-on-close bit if a TempFile doesn't reside on a local drive," because that regressed Windows 7 in #81051.

That change was meant to fix LLVM PR42623, which also references Rust #54216. It would be nice if some Windows user could verify if that was fixed on a nightly where we still had the change, roughly 2021-01-13 through 2021-02-28. But since it left Windows 7 unable to create any archives, we decided that regression was worse than the fix.

LLVM 48378 also reported a Windows 7 regression that seems to be the same root cause. Perhaps there will be a new update that makes it all work for Windows 7, so we can have the best of both. Another possibility suggested in a compiler meeting was to use runtime platform detection, skipping D81803's code on Windows 7, but letting us still have the bug fix on newer Windows.

Alternatively, when Rust eventually decides to stop supporting Windows 7, we can just drop the revert / reapply D81803.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-bugCategory: This is a bug.O-windowsOperating system: WindowsO-windows-7OS: Windows 7 or Windows Server 2008 R2 or etc.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions