regression 1.49: rustdoc runs indented documentation immediately after a header as a doctest

[Mark-Simulacrum]

• https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/bes.google-datastore1-generated/log.txt

My guess is that rustdoc's behavior on parsing doc attributes has changed or something like that -- I recall seeing a PR changing how we handle things. Maybe for example previously \n in an attribute worked and now doesn't?

cc @rust-lang/rustdoc

[jyn514]

Is there a way to see the full source for this? The error sounds like it's a doctest or something, not documentation directly.

[Mark-Simulacrum]

It's a public repo, https://github.com/bes/google-datastore1-generated/blob/master/src/lib.rs#L1

[Mark-Simulacrum]

https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/auto-0.0.8/log.txt might also be related (that one is on crates.io)

[jyn514]

The bug is that this is being interpreted as a doctest instead of normal documentation. Not sure why yet.

[Mark-Simulacrum]

https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/glutin-0.25.1/log.txt also seems to do the same

edit: and

• https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/initial_conditions-0.4.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/ruckus-2d-0.1.1/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/tox_encryptsave-0.1.0/log.txt

[jyn514]

I think this was fa1b15f.

[jyn514]

MCVE:

//!# Header
//!    x

Stable ignores it, beta runs x as a doctest.

[jyn514]

For context,

//!# Header
//!
//!    x

is run on a doctest on stable. So maybe newlines are getting discarded somewhere?