Skip to content

Some MIR dumps differ between little and big endian #79799

Description

in #77413 it was noted that MIR dumps in our test suite somtimes differ between little and big endian, making our test suite fail on big endian. This is just about MIR pretty printing.

All that needs to be done is to pull out

match ty.kind() {
ty::Int(_) | ty::Uint(_) | ty::Bool | ty::Char | ty::Float(_) => {}
// Unit type
ty::Tuple(tys) if tys.is_empty() => {}
ty::FnDef(..) => {}
into a separate function that returns true if the verbose printing should be used and then make it recurse on ty::Tuple and ty::Array elements.

You can then run rerun tests separately for 64bit and 32bit (the latter via e.g. --target i686-unknown-linux-gnu)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

A-mir-optArea: MIR optimizationsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions