Tracking Issue for feature(string_drain_as_str) - string::Drain::as_str()

[m-ou-se]

Tracking Issue for string_drain_as_str as introduced by #76525.

Api:

• Drain::as_str()
• AsRef<str> for Drain
• AsRef<[u8]> for Drain

The first one is now gated behind feature(string_drain_as_str). The other two are not available yet, as trait implementations cannot be unstable. These should be added (uncommented) when this feature is stabilized.

[JohnTitor]

Seems there's no blocker, could I ask you to kick off FCP to stabilize it?

[JohnTitor]

cc @rust-lang/libs-api If it's reasonable, it'd be great if someone starts FCP :)

[joshtriplett]

Do we have any confirmation of usage in the ecosystem? I don't see any problem with the method as designed, but can we confirm that it's being used?

[JohnTitor]

Oh sorry, I don't have the real world use case, unfortunately. I just thought this is straightforward and makes the conversion around .drain(..) easier. And we cannot make any use that requires AsRef because it's hidden until we stabilize the feature.

[m-ou-se]

@rfcbot merge

[rfcbot]

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @m-ou-se
• @yaahc

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.