Skip to content

Remove fn pretty_printing_compatibility_hack  #73933

Open
@petrochenkov

Description

@petrochenkov

#73345 adds a hack to support some older versions of proc-macro-hack and procedural-masquerade which included incorrect asserts.
The hack detects some specific enums used by those crates literally by their names and names of their variants.

Using newer versions of those crates fixes the issues

  • proc-macro-hack requires a major version bump so it doesn't happen automatically
  • for procedural-masquerade only a bugfix version update is required, so cargo update should do the job, but the old version is fixed in hundreds of Cargo.locks according to crater.

This hack needs to be removed eventually.
Now it's July 1 2020, so on July 1 2021 or later we need to run crater once more to estimate the use of these old versions again.
Then we could assume that crates not updating from outdated versions for so long are not maintained and we can break them and remove the hack.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)A-prettyArea: Pretty printing (including `-Z unpretty`)A-proc-macro-back-compatArea: Backwards compatibility hacks for proc macrosA-proc-macrosArea: Procedural macrosC-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions