Unable to find variable "NO_TYPE_FILTER" during ./x.py test

[dtolnay]

When running ./x.py test on my workstation (linux, x86_64) against the current master branch, it fails in the following way:

...

Testing error-index stage2
doc tests for: /git/rust/build/x86_64-unknown-linux-gnu/test/error-index.md
	finished in 5.282
Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 210 tests
iiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii 100/210
iiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii 200/210
iiiiiiiiii
test result: ok. 0 passed; 0 failed; 210 ignored; 0 measured; 0 filtered out

	finished in 0.078
doc tests for: /git/rust/src/doc/rustdoc/src/advanced-features.md
doc tests for: /git/rust/src/doc/rustdoc/src/command-line-arguments.md
doc tests for: /git/rust/src/doc/rustdoc/src/documentation-tests.md
doc tests for: /git/rust/src/doc/rustdoc/src/how-to-write-documentation.md
doc tests for: /git/rust/src/doc/rustdoc/src/lints.md
doc tests for: /git/rust/src/doc/rustdoc/src/passes.md
doc tests for: /git/rust/src/doc/rustdoc/src/the-doc-attribute.md
doc tests for: /git/rust/src/doc/rustdoc/src/unstable-features.md
doc tests for: /git/rust/src/doc/rustdoc/src/what-is-rustdoc.md
	finished in 0.928
doc tests for: /git/rust/src/doc/unstable-book/src/compiler-flags/control-flow-guard.md
doc tests for: /git/rust/src/doc/unstable-book/src/compiler-flags/emit-stack-sizes.md
doc tests for: /git/rust/src/doc/unstable-book/src/compiler-flags/profile.md
doc tests for: /git/rust/src/doc/unstable-book/src/compiler-flags/report-time.md
doc tests for: /git/rust/src/doc/unstable-book/src/compiler-flags/sanitizer.md
doc tests for: /git/rust/src/doc/unstable-book/src/compiler-flags/self-profile-events.md
doc tests for: /git/rust/src/doc/unstable-book/src/compiler-flags/self-profile.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/abi-msp430-interrupt.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/abi-ptx.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/arbitrary-enum-discriminant.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/box-patterns.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/box-syntax.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/c-variadic.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/cfg-sanitize.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/const-fn.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/crate-visibility-modifier.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/custom-test-frameworks.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/doc-alias.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/doc-cfg.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/external-doc.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/generators.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/impl-trait-in-bindings.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/infer-static-outlives-requirements.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/intrinsics.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/lang-items.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/link-args.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/marker-trait-attr.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/member-constraints.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/no-sanitize.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/non-ascii-idents.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/optin-builtin-traits.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/or-patterns.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/plugin.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/repr128.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/trait-alias.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/transparent-unions.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/try-blocks.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/unboxed-closures.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/unsized-locals.md
doc tests for: /git/rust/src/doc/unstable-book/src/language-features/unsized-tuple-coercion.md
doc tests for: /git/rust/src/doc/unstable-book/src/library-features/asm.md
doc tests for: /git/rust/src/doc/unstable-book/src/library-features/c-variadic.md
doc tests for: /git/rust/src/doc/unstable-book/src/library-features/concat-idents.md
doc tests for: /git/rust/src/doc/unstable-book/src/library-features/fn-traits.md
doc tests for: /git/rust/src/doc/unstable-book/src/library-features/global-asm.md
doc tests for: /git/rust/src/doc/unstable-book/src/library-features/test.md
doc tests for: /git/rust/src/doc/unstable-book/src/library-features/trace-macros.md
doc tests for: /git/rust/src/doc/unstable-book/src/library-features/try-trait.md
doc tests for: /git/rust/src/doc/unstable-book/src/the-unstable-book.md
	finished in 5.272
doc tests for: /git/rust/src/doc/rustc/src/json.md
doc tests for: /git/rust/src/doc/rustc/src/linker-plugin-lto.md
doc tests for: /git/rust/src/doc/rustc/src/lints/groups.md
doc tests for: /git/rust/src/doc/rustc/src/lints/index.md
doc tests for: /git/rust/src/doc/rustc/src/lints/levels.md
doc tests for: /git/rust/src/doc/rustc/src/lints/listing/allowed-by-default.md
doc tests for: /git/rust/src/doc/rustc/src/lints/listing/deny-by-default.md
doc tests for: /git/rust/src/doc/rustc/src/lints/listing/warn-by-default.md
doc tests for: /git/rust/src/doc/rustc/src/profile-guided-optimization.md
doc tests for: /git/rust/src/doc/rustc/src/targets/custom.md
doc tests for: /git/rust/src/doc/rustc/src/targets/index.md
doc tests for: /git/rust/src/doc/rustc/src/what-is-rustc.md
	finished in 1.133
unable to find variable "NO_TYPE_FILTER"


command did not execute successfully: "/usr/bin/node" "/git/rust/src/tools/rustdoc-js-std/tester.js" "/git/rust/build/x86_64-unknown-linux-gnu/doc" "/git/rust/src/test/rustdoc-js-std"
expected success, got: exit code: 1


failed to run: /git/rust/build/bootstrap/debug/bootstrap test
Build completed unsuccessfully in 0:01:47

Mentioning @GuillaumeGomez and @kinnison because NO_TYPE_FILTER appears to be related to #69402. Any idea what may be going on?

Indeed rerunning the command that it says failed does fail:

$ "/usr/bin/node" "/git/rust/src/tools/rustdoc-js-std/tester.js" "/git/rust/build/x86_64-unknown-linux-gnu/doc" "/git/rust/src/test/rustdoc-js-std"
unable to find variable "NO_TYPE_FILTER"

The node version on my machine is:

$ /usr/bin/node --version
v10.15.2

[kinnison]

I'm unable to reproduce this. (though lldb tests currently fail for me, so I had to specifically run the rustdoc-js-std suite directly)

[dtolnay]

Seems to work again after an x.py clean. It may be worth reopening and investigating if it happens again, but for now it could have just been one problematic commit that left some stale JS in the build directory.