Open
Description
openedon Sep 26, 2019
This is a tracking issue for #[cfg(version(..))]
(rust-lang/rfcs#2523).
Steps:
- Implement the RFC (cc @rust-lang/compiler -- can anyone write up mentoring instructions?)
- Adjust documentation (see instructions on rustc-guide)
- Stabilization PR (see instructions on rustc-guide)
Unresolved questions:
-
What is
cfg(version(...))
relative to in terms of nightly compilers?We could check against what
rustc --version
says, e.g. nightly being1.40.0
, beta being1.39.0
, and stable being1.38.0
. We could also havecfg(version(...))
at most be relative to the beta compiler. See the RFC for a longer discussion. -
Should we also support
version = "..."
so that crates having a MSRV below whenversion(...)
was stabilized can use the flag? -
Dependency updates cause language changes (src tarballs are vendored without respecting lockfile #79010)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
Blocker: Approved by a merged RFC but not yet implemented.Category: A tracking issue for an RFC or an unstable feature.`#![feature(cfg_version)]`Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.Relevant to the language team, which will review and decide on the PR/issue.