rustup: nightly 2018-12-25 fails to install

[matthiaskrgr]

Looks like I'm not getting a new nightly for Christmas 😢

rustup update

info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'beta-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2018-12-25, rust version 1.33.0-nightly (f960f377f 2018-12-24)
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: downloading component 'rls'
info: downloading component 'clippy'
info: downloading component 'llvm-tools-preview'
info: downloading component 'rust-analysis'
info: downloading component 'rust-src'
info: downloading component 'rustfmt'
info: removing component 'rustc'
info: removing component 'rust-std'
info: removing component 'cargo'
info: removing component 'rust-docs'
info: removing component 'rls'
info: removing component 'clippy'
info: removing component 'llvm-tools-preview'
info: removing component 'rust-analysis'
info: removing component 'rust-src'
info: removing component 'rustfmt'
info: installing component 'rustc'
info: installing component 'rust-std'
info: rolling back changes
error: could not rename component file from '/home/matthias/.rustup/tmp/ronagpiu3nt6eloc_dir/bk' to '/home/matthias/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share'
error: could not rename component file from '/home/matthias/.rustup/tmp/9k8l7uv_ss553dk5_dir/bk' to '/home/matthias/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc'
error: could not rename component file from '/home/matthias/.rustup/tmp/ki2c_xzhvwcjkabo_dir/bk' to '/home/matthias/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu'
error: could not rename component file from '/home/matthias/.rustup/tmp/odxfao3_dovk8n4q_dir/bk' to '/home/matthias/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/man'
error: failed to install component: 'rust-std-x86_64-unknown-linux-gnu', detected conflict: '"lib/rustlib/x86_64-unknown-linux-gnu/lib/libLLVM-8svn.so"'
info: checking for self-updates

       stable-x86_64-unknown-linux-gnu unchanged - rustc 1.31.1 (b6c32da9b 2018-12-18)
         beta-x86_64-unknown-linux-gnu unchanged - rustc 1.32.0-beta.6 (a01b0bf0f 2018-12-19)
  nightly-x86_64-unknown-linux-gnu update failed - rustc 1.33.0-nightly (2d3e909e4 2018-12-22)

[matthiaskrgr]

I checked verbose mode but didnt see anything interesting, just a ton of
verbose: creating temp {file,directory}

[matthiaskrgr]

This also reproduces on travis ci: https://travis-ci.org/matthiaskrgr/cargo-cache/jobs/471994137#L434

[Mark-Simulacrum]

cc @rust-lang/infra @rust-lang/dev-tools @pietroalbini @kennytm

[ishitatsuyuki]

#56944 seems the most relevant. cc @alexcrichton

[retep998]

Windows appears to be unaffected.

[kennytm]

PRs involved: ddab10a...f960f37

Failed to install on macOS too.

[alexcrichton]

I'm about 95% sure that this is #56944. It's fine to revert it quickly as I won't have time to make a fix until 2019!