x.py build no longer works with outdated submodules

[matthiaskrgr]

If a submodule is not up to date and I have submodules = true set in the config.toml and run ./x.py build, crashes:

Updating only changed submodules
Updating submodule src/tools/clippy
usage: git submodule [--quiet] add [-b <branch>] [-f|--force] [--name <name>] [--reference <repository>] [--] <repository> [<path>]
   or: git submodule [--quiet] status [--cached] [--recursive] [--] [<path>...]
   or: git submodule [--quiet] init [--] [<path>...]
   or: git submodule [--quiet] deinit [-f|--force] (--all| [--] <path>...)
   or: git submodule [--quiet] update [--init] [--remote] [-N|--no-fetch] [-f|--force] [--checkout|--merge|--rebase] [--[no-]recommend-shallow] [--reference <repository>] [--recursive] [--] [<path>...]
   or: git submodule [--quiet] summary [--cached|--files] [--summary-limit <n>] [commit] [--] [<path>...]
   or: git submodule [--quiet] foreach [--recursive] <command>
   or: git submodule [--quiet] sync [--recursive] [--] [<path>...]
   or: git submodule [--quiet] absorbgitdirs [--] [<path>...]
failed to run: git submodule -q sync --progress src/tools/clippy
Build completed unsuccessfully in 0:00:00

This used to work before 16329b0 , probably caused by #56933
cc @clarcharr

[clarfonthey]

Oh, I guess that my test wasn't thorough enough. Posted my comments in #57082.

[zackmdavis]

This still bit me yesterday.

zmd@MutualBestResponse:~/Code/rust$ ./x.py build --stage 1 
Updating only changed submodules
Updating submodule src/doc/rustc-guide
usage: git submodule [--quiet] add [-b <branch>] [-f|--force] [--name <name>] [--reference <repository>] [--] <repository> [<path>]
   or: git submodule [--quiet] status [--cached] [--recursive] [--] [<path>...]
   or: git submodule [--quiet] init [--] [<path>...]
   or: git submodule [--quiet] deinit [-f|--force] [--] <path>...
   or: git submodule [--quiet] update [--init] [--remote] [-N|--no-fetch] [-f|--force] [--checkout|--merge|--rebase] [--reference <repository>] [--recursive] [--] [<path>...]
   or: git submodule [--quiet] summary [--cached|--files] [--summary-limit <n>] [commit] [--] [<path>...]
   or: git submodule [--quiet] foreach [--recursive] <command>
   or: git submodule [--quiet] sync [--recursive] [--] [<path>...]
failed to run: git submodule update --init --recursive --progress src/doc/rustc-guide
Build completed unsuccessfully in 0:00:00

#57082 only removed one of the two --progress arguments introduced in #56933. (I'm still on Ubuntu Xenial, which is still in service until 2021 and ships Git 2.7.4. I wonder if would it be too petty if I sent a PR to make bootstrap.py check the Git version in order to decide whether to pass --progress? I think it's convenient to be able to hack on rustc with a moderately old Git version.)

[theronic]

Just got nailed by this on a Debian install trying to custom compile Rust for MIPS. Removing the --progress argument got me past this, thanks @zackmdavis.