EvaluationCache overwrites its entries

[Zoxc]

When the insertion to EvaluationCache is changed to use HashMapExt::insert_same. It triggers an the assertion which checks that the old value is the same as the new one. This is because the DepNodeIndex changed.

Backtrace
Log output

cc @arielb1 @nikomatsakis

[sasurau4]

@nikomatsakis
I looked into this issue.
In #49834, the build seems failed at build stage0 core and left FIXME comment.
When I changed the code same to #73792 and turn on parallel-compiler = true in config.toml, I met following tests failed but couldn't reproduce the build error same as #49834.

failures:
    [ui] ui/associated-types/defaults-cyclic-fail-1.rs
    [ui] ui/associated-types/defaults-cyclic-fail-2.rs
    [ui] ui/privacy/privacy2.rs
    [ui] ui/privacy/privacy3.rs
    [ui] ui/type_length_limit.rs

The cause of test fails are snapshot diffs mentioned at #75760, so this issue seems solved.
Any other information or investigation needed? I'll work on this.