Rustc no longer builds for msvc 17

[snf]

It appears to be since this commit yesterday: d69b248#diff-9a46b13a265be2ded97369dddf5037f5

@alexcrichton can you have a look at it?, discussing in IRC, it seems that changing the line 88 back from "build/bin" to only "bin" does the work.

[alexcrichton]

@snf can you provide more logs for this build?

[ollie27]

https://pastebin.mozilla.org/9079141 was the log posted on IRC. The issue is that when using MSBuild as the cmake generator llvm-config.exe is located in llvm\bin\llvm-config.exe and llvm\build\Release\bin\llvm-config.exe not llvm\build\bin\llvm-config.exe.

[retep998]

Also please never hardcode / in paths. That should be dir.join("build").join("bin"); due to certain conditions where / is treated as a literal character and not a path separator, such as \\?\ paths.

[alexcrichton]

Ah thanks @ollie27! Yes I can look into fixing this.