Closed
Description
openedon Jan 25, 2018
The ARCH_TABLE in compiletest contains a useless entry for powerpc64.
https://github.com/rust-lang/rust/blob/79b25c666fec/src/tools/compiletest/src/util.rs#L34
The only user of that table is get_arch which scans the table sequentially to see if a target contains an architecture in the table. Since powerpc is a substring of powerpc64, the entry for powerpc64 will never match anything and is therefore useless.
This also means that all ignore-powerpc64 headers in the testsuite currently do nothing. I also found a few ignore-powerpc64le headers which probably do nothing as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
Area: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.Target: PowerPC processorsTarget: PowerPC processorsRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.