ICE on destructuring

[lucian1900]

When trying to compile https://github.com/lucian1900/persistent/blob/d6e8d53a1f5207bd9f33121b9bb20f2bb29a9feb/persistent.rs for testing, this happens:

$ RUST_LOG=rustc=0,::rt::backtrace rustc --test persistent.rs 
persistent.rs:145:11: 148:31 error: mismatched types: expected `@PersistentVector` but found `@PersistentVector<int>` (expected a type with 0 type params but found one with 1 type params)
persistent.rs:145     assert(match two {
persistent.rs:146         @Full(leaves) => leaves,
persistent.rs:147         _ => @[],
persistent.rs:148     } == @[@Leaf(x), @Leaf(y)]);
rust: task failed at 'Assertion len(v1) == len(v2) failed', /build/buildd/rust-0.4/src/rustc/rustc.rc:1
/usr/bin/../lib/librustrt.so(_ZN9rust_task13begin_failureEPKcS1_m+0x5d)[0x7f8731ec87bd]
/usr/bin/../lib/librustrt.so(+0x323fd)[0x7f8731ee03fd]
/usr/bin/../lib/librustrt.so(upcall_fail+0x1a8)[0x7f8731ecb0a8]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33a5af)[0x7f873244b5af]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33537f)[0x7f873244637f]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x3333af)[0x7f87324443af]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x332d47)[0x7f8732443d47]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33240e)[0x7f873244340e]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33a834)[0x7f873244b834]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33537f)[0x7f873244637f]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x3333af)[0x7f87324443af]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x332d47)[0x7f8732443d47]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33240e)[0x7f873244340e]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33c90b)[0x7f873244d90b]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33ef15)[0x7f873244ff15]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33f526)[0x7f8732450526]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x6899a0)[0x7f873279a9a0]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x33f6da)[0x7f87324506da]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x37e06d)[0x7f873248f06d]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x37b6f3)[0x7f873248c6f3]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x378f5a)[0x7f8732489f5a]
/usr/bin/../lib/libsyntax-84efebcb12c867a2-0.4.so(+0xad84d)[0x7f8732c2284d]
/usr/bin/../lib/libsyntax-84efebcb12c867a2-0.4.so(+0xad6b4)[0x7f8732c226b4]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(_ZN6middle6typeck11check_crate17_586991a76ae1b8af3_04E+0xd49)[0x7f8732569369]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(_ZN6driver6driver12compile_upto17_59b1863f8cf68bb13_04E+0x1649)[0x7f873276fd19]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(+0x6899a0)[0x7f873279a9a0]
/usr/bin/../lib/librustc-c84825241471686d-0.4.so(_ZN6driver6driver13compile_input16_7610df88918688e3_04E+0xbd)[0x7f873277301d]
rustc[0x408f61]
rustc[0x4122d4]
rustc[0x40e753]
rustc[0x40d40c]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0x758ff)[0x7f87334b38ff]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0xb51d0)[0x7f87334f31d0]
/usr/bin/../lib/librustrt.so(_Z18task_start_wrapperP10spawn_args+0x24)[0x7f8731ec8f64]
error: internal compiler error: unexpected failure
note: the compiler hit an unexpected failure path. this is a bug
note: try running with RUST_LOG=rustc=0,::rt::backtrace to get further details and report the results to github.com/mozilla/rust/issues
rust: task failed at 'explicit failure', /build/buildd/rust-0.4/src/rustc/driver/rustc.rs:275
/usr/bin/../lib/librustrt.so(_ZN9rust_task13begin_failureEPKcS1_m+0x5d)[0x7f8731ec87bd]
/usr/bin/../lib/librustrt.so(+0x323fd)[0x7f8731ee03fd]
/usr/bin/../lib/librustrt.so(upcall_fail+0x1a8)[0x7f8731ecb0a8]
rustc(_rust_main+0x838)[0x411ae8]
rustc[0x4122d4]
/usr/bin/../lib/librustrt.so(_Z18task_start_wrapperP10spawn_args+0x24)[0x7f8731ec8f64]
rust: domain main @0x1d0b200 root task failed
rust: task failed at 'killed', /build/buildd/rust-0.4/src/libcore/task.rs:663
/usr/bin/../lib/librustrt.so(_ZN9rust_task13begin_failureEPKcS1_m+0x5d)[0x7f8731ec87bd]
/usr/bin/../lib/librustrt.so(+0x323fd)[0x7f8731ee03fd]
/usr/bin/../lib/librustrt.so(upcall_fail+0x1a8)[0x7f8731ecb0a8]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(_ZN4task5yield16_9531951b4f79f8b3_04E+0xbd)[0x7f873349cecd]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0x90336)[0x7f87334ce336]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(_ZN7private11weaken_task16_cf742a1b771015c3_04E+0xd2)[0x7f87334ce172]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0x9006b)[0x7f87334ce06b]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0xb51d0)[0x7f87334f31d0]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0x8f3c0)[0x7f87334cd3c0]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0x8ed5e)[0x7f87334ccd5e]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0x8e3c6)[0x7f87334cc3c6]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0x758ff)[0x7f87334b38ff]
/usr/bin/../lib/libcore-c3ca5d77d81b46c1-0.4.so(+0xb51d0)[0x7f87334f31d0]
/usr/bin/../lib/librustrt.so(_Z18task_start_wrapperP10spawn_args+0x24)[0x7f8731ec8f64]

[catamorphism]

I'm guessing the error message is confusing because type parameters don't get printed out (this is an infelicity), and also the first error message isn't setting up data structures properly so typechecking can continue, which is why you see the ICE. Both should be fixed.

[youknowone]

Test case is outdated. (both syntax and library)

[catamorphism]

Yes, the test case would need quite a bit of updating. Also, I've overhauled the code relating to type errors (about to land) so the ICE should be fixed. I'm closing this, but if you can reproduce it with code that works on trunk, feel free to reopen or file a new issue.