temp dir `rustc.*` is deleted even when `-C save-temps` applys

[liigo]

"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\liblibc-b8291b00ed3b11ca.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\libstd-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\libpanic_unwind-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\libunwind-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\liblibc-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\librand-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\libcollections-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\liballoc-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\liballoc_system-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\librustc_unicode-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\libcore-1357b93f.rlib" 
"C:\\Users\\liigo\\AppData\\Local\\Temp\\rustc.wRCEMTOH5I1k\\libcompiler_builtins-1357b93f.rlib" 

[Mark-Simulacrum]

Tagging as E-easy and E-mentor. The fix here involves changing the code here to call let _ = tmpdir.into_path() to prevent the temp dir from destroying itself. This should be wrapped in an if like this one:

rust/src/librustc_trans/back/link.rs

Lines 235 to 242 in 380100c

	if !sess.opts.cg.save_temps {
	if sess.opts.output_types.should_trans() {
	for obj in object_filenames(trans, outputs) {
	remove(sess, &obj);
	}
	}
	remove(sess, &outputs.with_extension(METADATA_OBJ_NAME));
	}

.

[slo1]

Hi, I want to try working on this.

[Mark-Simulacrum]

Go ahead! Let me know if you need any assistance - feel free to either reach out here or over IRC (simulacrum is my handle there).