Add --unpretty=mir to rustc --help -v

[bluss]

Add --unpretty=mir to rustc --help -v

It's hidden from the help output.

[nagisa]

We have multiple ways to output MIR, but I think -Z dump-mir is the preferred one (also outputs the most information). Should we go ahead and remove the rest cc @rust-lang/compiler?

[eddyb]

@nagisa -Z dump-mir is useless if I want to print out the whole crate's MIR at once.
Plus, it makes a complete mess of my working directory.

OTOH, we should probably move --unpretty and the unstable --pretty forms (are there any left?) to -Z, it's really annoying to type -Z unstable-options when you need any of them.

[nagisa]

We could expand dump-mir with various way to dump MIR (including the whole-crate dump). I myself prefer graphviz, for example, but there’s no way to dump_mir+graphviz currently.

[nikomatsakis]

I do dump-mir='' to dump the whole crate at once. The one thing it lacks is
graphviz output which is sometimes nice.

On Sep 14, 2016 11:36 AM, "Simonas Kazlauskas" notifications@github.com
wrote:

We could expand dump-mir with various way to dump MIR (including the
whole-crate dump). I myself prefer graphviz, for example, but there’s no
way to dump_mir+graphviz currently for example.

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#36473 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJeZqATHl8FRzmB0m1aa9IAnSMzhUorks5qqBRhgaJpZM4J8nd9
.

[eddyb]

@nikomatsakis Does that result in one single file? I mostly use --unpretty=mir together with a pager and sometimes jump around functions.

[nikomatsakis]

@eddyb no it has multiple files (which I prefer, but YMMV)

[Mark-Simulacrum]

We have --emit=mir today; does that fit the bill?

[RalfJung]

Having output to stdout (like --unpretty does) is sometimes much more useful than having it in files (even more so since the files have names that don't say anything about which function they contain).

[jyn514]

--unpretty is now an unstable -Z option and shows up in -Z help:

    -Z                       unpretty=val -- present the input source, unstable (and less-pretty) variants;
        valid types are any of the types for `--pretty`, as well as:
        `expanded`, `expanded,identified`,
        `expanded,hygiene` (with internal representations),
        `everybody_loops` (all function bodies replaced with `loop {}`),
        `ast-tree` (raw AST before expansion),
        `ast-tree,expanded` (raw AST after expansion),
        `hir` (the HIR), `hir,identified`,
        `hir,typed` (HIR with types for each node),
        `hir-tree` (dump the raw HIR),
        `mir` (the MIR), or `mir-cfg` (graphviz formatted MIR)

So I think this can be closed; --help -v doesn't show any other unstable options and I don't think unpretty should be special.

[jyn514]

Oh hmm, --pretty is missing though. Does pretty do anything --unpretty doesn't? It seems weird to have both.

$ rustc --pretty=x -Z unstable-options
error: argument to `pretty` must be one of `normal`, `expanded`, `identified`, or `expanded,identified`; got x