Skip to content

Create dep-node representing the overall trans of each partition #34038

Closed
@nikomatsakis

Description

@nikomatsakis

Right now we have dep-nodes representing the trans for individual items. We should create a dep-node also for each partition. These dep-nodes will not have a DefId but rather the string representing the partition name. They will have incoming edges from the trans of each individual item -- some trans items, such as drop glue, may not have their own individual item and can just be lumped under the partition node.

Upon startup, when the dep-node for a partition is deemed to be dirty, we will also delete the associated .o file from the disk. The same is true if the hash of the partition contents (cc #34037) changes.

One question: could it somehow happen (I don't think so...but maybe?) that a partition just ceases to exist, but none of the inputs change? I guess one example might be changing the partition strategy? We may just want to do a little walk over the graph and delete extra nodes.

cc @michaelwoerister

Metadata

Metadata

Assignees

Labels

T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions