-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
In rust, and in programming in general, there are two similar classes of errors you can make with names:
- undefined/unknown/unresolved: trying to refer to something that has is not defined. this corresponds to E0425 in rust.
- unused: defining something, and then not using it. this corresponds to the
unused
lints in rustc.
despite it's name, unused-revision-names
controls how to treat references to revision names that have not been declared. revision names that are defined and not referenced are never an error.
while there is some sense in which these revisions are never "used" (i.e. the test is never run with that revision), this seems needlessly confusing and contrary to the typical meaning of these words.
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.