Skip to content

Need test coverage for attr edge-cases (ambiguity, ignored positions, etc) #143911

Open
@workingjubilee

Description

@workingjubilee

We have a variety of edge-cases involving attributes that are either simply untested or under-tested, and certainly not tested for every attribute where it is relevant. As most attributes are a series of special-cases (though less so now) they each need testing.

A key issue is that they have interactions with proc-macro attributes and such.

We are currently allowing this to happen and not blocking PRs on fixes in this area because we already have legacy problems in this lack of coverage and we are in the middle of a migration.

This came up in

Metadata

Metadata

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions