Skip to content

new build_helper::compiletest module for safer invocations of compiletest by bootstrap #135645

@lolbinarycat

Description

@lolbinarycat

currently bootstrap just uses strings to represent various compiletest arguments, such as mode.

obviously it would be better to use enums for these, as they are much less vulnerable to typos.

compiletest already has enum definitions for these (in common.rs), and the two already have a shared dependency (build_helper), and build_helper already has access to serde.

i would be willing to work on this refactor, if people think it would be a good idea.

Metadata

Metadata

Assignees

Labels

A-compiletestArea: The compiletest test runnerC-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions