Skip to content

The combination of alloc_error_handler and target_features_11 is unsound #134234

Open
@veluca93

Description

The following code compiles:

#![feature(target_feature_11, alloc_error_handler)]

#[target_feature(enable = "avx")]
#[alloc_error_handler]
fn f(_: std::alloc::Layout) -> ! {
    panic!()
}

However, this is unsound if the allocation error handler is invoked on a machine that does not support avx.

The alloc_error_handler feature is still unstable, tracking issue: #51540

This issue emerged during the stabilization PR for target_features_11: #134090

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.F-target_feature_11target feature 1.1 RFCI-unsoundIssue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/SoundnessT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.requires-nightlyThis issue requires a nightly compiler in some way.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions