Skip to content

Tracking Issue for const_char_classify #132241

Closed

Description

@ultrabear

Feature gate: #![feature(const_char_is_digit)] #![feature(const_char_classify)]

This is a tracking issue for supporting char::is_digit and char::is_whitespace in const scenarios.

Public API

impl char {
    pub const fn is_digit(self, radix: u32) -> bool;
    pub const fn is_whitespace(self) -> bool;
}

Steps / History

Unresolved Questions

  • None yet.

Activity

  1. added
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    T-libs-api[DEPRECATED; DO NOT USE]
    on Oct 27, 2024
  2. added a commit that references this issue on Oct 28, 2024
  3. added a commit that references this issue on Oct 28, 2024
  4. changed the title [-]Tracking Issue for `const_char_is_digit`[/-] [+]Tracking Issue for `const_char_classify`[/+] on Nov 5, 2024
  5. added a commit that references this issue on Nov 6, 2024
  6. RalfJung commented on Feb 24, 2025

    @RalfJung
    Member

    @rust-lang/libs-api @rust-lang/wg-const-eval these are two fairly small methods that have been stable since 1.0 and that are trivial to const-stabilize, so I think we should go ahead and do that. :)

    impl char {
        pub const fn is_digit(self, radix: u32) -> bool;
        pub const fn is_whitespace(self) -> bool;
    }
  7. dtolnay commented on Feb 24, 2025

    @dtolnay
    Member

    @rfcbot fcp merge

  8. rfcbot commented on Feb 24, 2025

    @rfcbot

    Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

    No concerns currently listed.

    Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  9. added
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.
    on Feb 24, 2025
  10. added
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    and removed
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Feb 24, 2025
  11. rfcbot commented on Feb 24, 2025

    @rfcbot

    🔔 This is now entering its final comment period, as per the review above. 🔔

  12. added and removed
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Mar 6, 2025
  13. rfcbot commented on Mar 6, 2025

    @rfcbot

    The final comment period, with a disposition to merge, as per the review above, is now complete.

    As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

    This will be merged soon.

  14. added a commit that references this issue on Mar 7, 2025
  15. added a commit that references this issue on Mar 7, 2025
  16. added a commit that references this issue on Mar 7, 2025
  17. added a commit that references this issue on Mar 7, 2025
  18. added a commit that references this issue on Mar 14, 2025
  19. added this to the 1.87.0 milestone on Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions