Skip to content

wasm32_wasip1_threads's llvm_target is mistake #131007

Open
@oligamiq

Description

about /compiler/rustc_target/src/spec/targets/wasm32_wasip1_threads.rs
https://github.com/rust-lang/rust/blob/master/compiler/rustc_target/src/spec/targets/wasm32_wasip1_threads.rs#L61
now:

llvm_target: "wasm32-wasi".into(),

I think:

llvm_target: "wasm32-wasi-threads".into(),

--target wasm32-wasi: After this argument, the linked .o files are treated as wasm32-wasi.

= note: wasm-ld: error: --shared-memory is disallowed by dlmalloc.o because it was not compiled with the 'atomics' or 'bulk-memory' features.

If you change it, it will be linkable.

Meta

rustc --version --verbose:

rustc 1.81.0 (eeb90cda1 2024-09-04)
binary: rustc
commit-hash: eeb90cda1969383f56a2637cbd3037bdf598841c
commit-date: 2024-09-04
host: x86_64-unknown-linux-gnu
release: 1.81.0
LLVM version: 18.1.7

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-linkageArea: linking into static, shared libraries and binariesC-bugCategory: This is a bug.O-wasmTarget: WASM (WebAssembly), http://webassembly.org/T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions