Skip to content

dylib-soname run-make test is not language independant #129362

Closed

Description

On an non-English system the run-make tests/run-make/dylib-soname test fails because it searches a english "needle" but readelf may print it in another language.

--- stderr -------------------------------
=== HAYSTACK ===

La section dynamique à l'offset 0x156868 contient 29 entrées :
  Étiquettes Type                         Nom/Valeur
 0x0000000000000001 (NEEDED)             Bibliothèque partagée : [libgcc_s.so.1]
 0x0000000000000001 (NEEDED)             Bibliothèque partagée : [libc.so.6]
 0x0000000000000001 (NEEDED)             Bibliothèque partagée : [ld-linux-x86-64.so.2]
 0x000000000000000e (SONAME)             Bibliothèque soname : [libfoo.so]
[..]

=== NEEDLE ===
Library soname: [libfoo.so]
thread 'main' panicked at [..]/rust/tests/run-make/dylib-soname/rmake.rs:17:14:
needle was not found in haystack
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Putting LC_ALL=C in my environment variable makes readelf use it's default (English) language.
We should probably do that for all the run-make tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions